application-services
application-services copied to clipboard
removed unused code from issue #4719 [ci full]
Pull Request checklist
- [x ] Quality: This PR builds and tests run cleanly
- Note:
- For changes that need extra cross-platform testing, consider adding
[ci full]to the PR title. - If this pull request includes a breaking change, consider cutting a new release after merging.
- For changes that need extra cross-platform testing, consider adding
- Note:
- [x ] Tests: This PR includes thorough tests or an explanation of why it does not
- [x ] Changelog: This PR includes a changelog entry in CHANGES_UNRELEASED.md or an explanation of why it does not need one
- Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
- [ x] Dependencies: This PR follows our dependency management guidelines
- Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them. Not needed tests because it was deletion of old code. Perhaps full ci to verify if all code is ok related to this issue Tests were not needed because I only removed code. Changelog were not altered because was just remung unused code
Codecov Report
Merging #4799 (086bdea) into main (df53ad8) will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## main #4799 +/- ##
=======================================
Coverage 81.53% 81.53%
=======================================
Files 49 49
Lines 5650 5650
=======================================
Hits 4607 4607
Misses 1043 1043
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update df53ad8...086bdea. Read the comment docs.
where is the code of this references ? i could not find this on the project maybe is another name ?
In .kt and .swift files in this repo under components/places/android and components/places/ios
@Grubba27 thanks a ton for this and apologies that it's gone stale! Lots have changed since so I'll proactively close this PR - however, if you are still interested in getting back to this (and rebasing/etc) post a comment here and I'll be happy to support with reviews and re-open it