application-services icon indicating copy to clipboard operation
application-services copied to clipboard

Published 20 hours ago • verified publisher icon mozilla

Investigate and remove unused Sync APIs and related implementations

Open data-sync-user opened this issue 3 years ago • 1 comments

Investigate the potential removal of these three methods since they don’t seem to be actually used by either consumer. Which also might have something to do with this: https://github.com/mozilla-mobile/fenix/issues/7227

  • wipe_local_history
  • delete_everything_history
  • prune_destructively

May be that we should remove these and discuss a better API that addresses what the consumers need.

┆Issue is synchronized with this Jira Task ┆epic: Places Follow-on Work

data-sync-user avatar Dec 08 '21 23:12 data-sync-user

That mozilla mobile issue is no showing, can i do this issue ? just remove these methods ?

Grubba27 avatar Jan 27 '22 04:01 Grubba27

➤ Sammy Khamis commented:

delete_everything_history is used by both iOS and Android and also used under-the-hood for wipe which is also used. I have removed that API from the task but kept the rest! https://github.com/mozilla/application-services/pull/5894 ( https://github.com/mozilla/application-services/pull/5894|smart-link )

data-sync-user avatar Nov 01 '23 19:11 data-sync-user