application-services icon indicating copy to clipboard operation
application-services copied to clipboard

Rewrite Nimbus.kt and FxaClient in terms of a decorator

Open jhugman opened this issue 4 years ago • 1 comments

Draft.

This is an implementation of Nimbus.kt with the proposed Uniffi decorators.

Many Nimbus method calls go through the NimbusClientDecorator, and almost all the methods which were forwarding to the NimbusClient have now disappeared.

It is for illustrative and exploratory purposes only at this time.

I will self-review to highlight what I learned in the process of doing it.

Pull Request checklist

  • [ ] Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • [ ] Tests: This PR includes thorough tests or an explanation of why it does not
  • [ ] Changelog: This PR includes a changelog entry in CHANGES_UNRELEASED.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • [ ] Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

jhugman avatar Oct 20 '21 12:10 jhugman

Codecov Report

Merging #4595 (6ca5b26) into main (51009b4) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4595   +/-   ##
=======================================
  Coverage   80.69%   80.69%           
=======================================
  Files          48       48           
  Lines        5217     5217           
=======================================
  Hits         4210     4210           
  Misses       1007     1007           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 51009b4...6ca5b26. Read the comment docs.

codecov-commenter avatar Nov 09 '21 19:11 codecov-commenter

Closing until further discussion is had.

jhugman avatar Oct 11 '22 14:10 jhugman