application-services icon indicating copy to clipboard operation
application-services copied to clipboard

Organize dependency versioning in gradle files.

Open jhugman opened this issue 4 years ago • 4 comments

Currently we have a disorganized management of dependency versions in our gradle files.

e.g.

     testImplementation 'androidx.test:core-ktx:1.2.0'
     implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"
     testImplementation "org.mozilla.telemetry:glean-forUnitTests:$project.ext.glean_version"

Here we have:

  • a bare version string
  • a variable referencing an ext variable containing the version string.
  • an unnecessarily complicated version of the same.

This issue requires a motivated Android engineer to bring order to this chaos of versioning.

For example, Fenix and Android Components use kotlin files for Dependency strings and Version strings.

    testImplementation Dependencies.androidx_test_core

In Dependencies.kt

const val androidx_test_core = "androidx.test:core-ktx:${Versions.AndroidX.test}"

Then in Versions.kt:

  object AndroidX {
        // …
        const val test = "1.3.0"
  }

┆Issue is synchronized with this Jira Task

jhugman avatar Apr 22 '21 18:04 jhugman

Working in this one!

lucastosetto avatar Sep 08 '21 01:09 lucastosetto

I am an Outreachy applicant. Can I work on this issue?

ria-19 avatar Oct 28 '21 06:10 ria-19

I am an Outreachy applicant. Can I work on this issue?

That sounds good to me! @lucastosetto mentioned working on this 1.5 months ago, but there's been no update since then, so I suspect it's not happening - @lucastosetto, please let us know if there's an update. but otherwise I think it's yours!

mhammond avatar Oct 28 '21 07:10 mhammond

Thank you for the response!

ria-19 avatar Oct 28 '21 07:10 ria-19

Hi @mhammond! Is this fixed? If not I'd like to work on this issue. Also where do i need to make this changes to? All the gradle files and then just have a common Dependencies.kt and Versions.kt for it?

nox1134 avatar Nov 10 '23 11:11 nox1134

This is still open. If there's something you don't understand in the initial description, please be specific about what it is.

mhammond avatar Nov 13 '23 16:11 mhammond

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1866337

Change performed by the Move to Bugzilla add-on.

mhammond avatar Nov 23 '23 22:11 mhammond