application-services icon indicating copy to clipboard operation
application-services copied to clipboard

Notify authentications attempts in invalid auth states

Open keianhzo opened this issue 5 years ago • 7 comments

This is the scenario we have in FxR:

  • User is not Logged in FxA
  • The user initiates a login flow in a window
  • Opens another window and starts another login flow
  • Finishes the login flow in the first window, everything goes good, the account is logged in
  • The user tries to finish the logging flow in the second window

Actual: No callback is received, we get an infinite spinner Expected: An authentication error or just show the "connected" page right away as the user is effectively connected.

It also happens if you reuse an old login url not matters if you are already logged in or not.

┆Issue is synchronized with this Jira Task ┆Epic: Important backlog

keianhzo avatar Jul 03 '20 12:07 keianhzo

/cc @grigoryk since it's not clear to me whether this is best addressed in a-s or a-c.

Actual: No callback is received, we get an infinite spinner

What's displaying this spinner, is it in the web content from accounts.firefox.com?

rfk avatar Jul 07 '20 05:07 rfk

Yes, sorry, I meant the spinner in the web content from accounts.firefox.com.

keianhzo avatar Jul 07 '20 08:07 keianhzo

Great, thanks. What I think should happen here in the error case is:

  • The app receives a message from web content saying the user signed in.
  • The app checks its local state, decides the signin attempt is invalid, and sends an error response back to web content
  • Web content sees the error response (or times out waiting for it) and transitions to an error page of some sort.

I'm not sure how much of that needs to be added on the application side vs how much on the web-content side.

@vladikoff, I seem to recall we deliberately didn't add an error response here for the first version, but I don't recall whether that was because it didn't seem necessary or because of some more complex technical reason. Any thoughts on the above?

rfk avatar Jul 07 '20 08:07 rfk

➤ Janet Dragojevic commented:

FxR no longer supported, closing.

data-sync-user avatar Mar 26 '21 22:03 data-sync-user

@jdragojevic Is FxR not supported anymore? FxR is still maintained and as long as I know we still have partnerships pending and eventually we will update to a newer GV/AC version.

keianhzo avatar Mar 27 '21 00:03 keianhzo

Apologies - I did not realize it was still a thing. Feel free to reopen if it's still an issue.

jdragojevic avatar Apr 01 '21 16:04 jdragojevic

@jdragojevic I don't have permissions to reopen it, can you please reopen to have it under the radar?

keianhzo avatar Apr 05 '21 16:04 keianhzo

Given this has been open for a few years I'll close it as stale - if we need to reopen it lets migrate it to Bugzilla in https://bugzilla.mozilla.org/describecomponents.cgi?product=Application%20Services

tarikeshaq avatar Apr 05 '24 15:04 tarikeshaq