application-services icon indicating copy to clipboard operation
application-services copied to clipboard

Retire the /account/devices/notify API?

Open rfk opened this issue 5 years ago • 2 comments

According to recently-added FxA server metrics, "devicesNotify" is the cause of more than half of all push notifications sent to clients:

Capture

These pushes correspond to clients calling the /accont/devices/notify endpoint to send each other push notifications. In practice I believe that only desktop does this, and for only two reasons: to notify another client that we've connected as a new device, and to notify another client that we sent it a tab.

We have other push notifications that serve these specific purposes now, generated automatically by the FxA server. So I don't think we can be getting a lot of value out of the client-driven notifications.

What do y'all think about retiring this endpoint, by:

  • Modifying the FxA server to turn this into a no-op
  • Removing the code that uses it from Desktop and allowing it to ride the trains
  • At some later date, entirely removing the route from the FxA server.

┆Issue is synchronized with this Jira Task ┆Epic: Important backlog

rfk avatar Jun 12 '20 03:06 rfk

+1 - although we might want to be careful re timing around Fennec - this might still end up being the thing that makes us find tabs sent via the clients collection in a timely manner.

mhammond avatar Jun 12 '20 05:06 mhammond

+1, see also https://github.com/mozilla/application-services/issues/3181.

eoger avatar Jun 12 '20 13:06 eoger

➤ Tarik Eshaq commented:

Looks like Desktop doesn’t use this endpoint anymore and retiring it is an FxA server question, so moving to FxA’s Jira and closing the github issue

data-sync-user avatar Apr 05 '24 15:04 data-sync-user