api.webmaker.org icon indicating copy to clipboard operation
api.webmaker.org copied to clipboard

'status' key in JSON response

Open ashleygwilliams opened this issue 9 years ago • 4 comments

would like more info on what the motivation was for adding a status attribute to the JSON response! it adds complication to building clients on top of the API. it also strikes me as redundant as HTTP should be enough information? potentially i am missing something. thanks.

ashleygwilliams avatar Aug 06 '15 17:08 ashleygwilliams

It doesn't need to be there. we could provide a v2.0 handler function that doesn't provide it.

hapi-version is already included in the server for us to make use of

cadecairos avatar Aug 06 '15 18:08 cadecairos

Do we have a way of tracking wants for non-backwards-compatible changes in the API? We can force an update of the app, though it isn't a pretty user experience. If there are enough things that pile up, it may be worth doing at some point. -- especially while we have few users.

simonwex avatar Aug 06 '15 18:08 simonwex

I just added a "breaking change" label we can use to track, well, breaking changes.

cadecairos avatar Aug 06 '15 18:08 cadecairos

error from ember:

WARNING: Encountered "status" in payload, but no model was found for model name "status" (resolved model name using webmaker-moderator@serializer:application:.modelNameFromPayloadKey("status"))

ashleygwilliams avatar Aug 10 '15 22:08 ashleygwilliams