addons icon indicating copy to clipboard operation
addons copied to clipboard

[Task]: Add @*.mozilla.org to RESERVED_ADDON_GUIDS

Open diox opened this issue 9 months ago • 2 comments

Description

Follow-up for https://github.com/mozilla/addons/issues/15423 and https://github.com/mozilla/addons/issues/15424

We recently added some guids to RESERVED_ADDON_GUIDS that were used internally by Firefox and decided to add a wildcard for @*.mozilla.org as a whole later, to prevent any further surprises. So @foo.mozilla.org, [email protected] etc would be prevented at submission time, unless the user has the SystemAddon:Submit permission

RESERVED_ADDON_GUIDS entries are typically synced with shipit but the consensus was that we wouldn't need to do that here, AMO reserved list can contain more than what shipit knows about (the opposite is not true).

Acceptance Criteria

  ### Milestones/checkpoints
  - [ ] New add-ons with guids matching `@*.mozilla.org` can't be submitted by a user without the `SystemAddon:Submit` permission

Checks

  • [x] If I have identified that the work is specific to a repository, I have removed "repository:addons-server" or "repository:addons-frontend"

┆Issue is synchronized with this Jira Task

diox avatar Mar 18 '25 11:03 diox

Can you add a motivation?

This might be too broad. Or, to be consistent, maybe not broad enough, for instance what about mozilla.com, or mozilla.ai etc?

wagnerand avatar Mar 18 '25 11:03 wagnerand

The list has 7 entries matching @*.mozilla.org, that's the motivation + not having to think about doing that next time a GUID is used in Firefox code.

This might be too broad. Or, to be consistent, maybe not broad enough, for instance what about mozilla.com, or mozilla.ai etc?

This is precisely about mozilla.org, not the other ones.

willdurand avatar Mar 18 '25 11:03 willdurand