mozilla
[Bug]: `make up` is still slow
What happened?
make up is still quite slow and takes 4 minutes to rebuild even with a very recent cache.
I had an up to date cache for rev https://github.com/mozilla/addons-server/commit/23b15add5d7263e36fef96e335378dd1e86bf96b and updated to https://github.com/mozilla/addons-server/commit/fd56be466fb0e27c7cd629a1b384bfd98e1cffb3
What did you expect to happen?
Much faster boot.
Is there an existing issue for this?
- [X] I have searched the existing issues
┆Issue is synchronized with this Jira Task
Can you also try running
time make up DOCKER_VERSION=latest
This will run using the latest docker image published to docker hub instead of a locally built one. If you are mostly interested in running the most recent version without really making patches, this could be an alternative for you?
Another thing you should try doing is cleaning up docker resources on your machine. Make sure you don't have dangling images/volumes and ensure docker has enough storage/memory access to run efficiently.
@KevinMind to pair with @wagnerand to see if there are some issues they can look solve by looking at it together live.
I think https://github.com/mozilla/addons-server/commit/91b0721ce6ba2a9a5de384d599e978dfbdb74721 put the final piece in place.
From my local testing, and now covered in CI, it seems like make up is running pretty stably under 1 minute, often under 20 seconds on my machine even when making changes to source files.
This should apply to branch changes naturally.
@wagnerand lmk on latest master what you think. Hopefully it is noticeably faster.