addons icon indicating copy to clipboard operation
addons copied to clipboard

[Task]: Mention max allowable filesize on developer hub when uploading a new version

Open abyrne-moz opened this issue 1 year ago • 2 comments

Description

The maximum file size supported in the developer hub for submitting an add-on is 200MB, but we do not mention this on the file submission page. This task is to update the page to mention this limit by appending this text to the upload page.

The maximum file size accepted is 200 MB. If your add-on is larger than 200 MB, it will fail validation.

image

Acceptance Criteria

  ### Acceptance Criteria
  - [ ] New text is displayed on the add-on version upload page

Checks

  • [X] If the issue is ready to work on, I have removed the "needs:info" label.

┆Issue is synchronized with this Jira Task

abyrne-moz avatar Jun 07 '24 08:06 abyrne-moz

This text should also be added to the Source Code submission upload page.

The maximum file size accepted is 200MB.

image

abyrne-moz avatar Jun 07 '24 09:06 abyrne-moz

Technically addons-server limits are more complex than that but it's not a bad limit to advertise.

diox avatar Jun 13 '24 14:06 diox

Added bonus:

Use some JS to trigger size detection when the file input is changed. In that, call setCustomValidity() with a custom message if the size is over the limit, and otherwise call it to reset it to '' if valid. The user would need to change the file if they want to continue.

If going that route though, they'd probably also need to be able to clear the input completely to start over.

diox avatar Sep 20 '24 17:09 diox

@diox That sort of sounds like its own separate issue? Or at least seems odd to include alongside this one

chrstinalin avatar Sep 20 '24 17:09 chrstinalin

Maybe, yes. We can file another issue, doesn't have to be bundled into that one.

diox avatar Sep 20 '24 19:09 diox

@chrstinalin now that the dust has settled and we are displaying it in a bunch of places I think we should fix that inconsistency between decimal vs binary format which we've ignored before - display "209.7 MB" is kinda weird. It looks like setting MAX_UPLOAD_SIZE = 200 * 1000 * 1000 would do the trick.

diox avatar Oct 14 '24 12:10 diox

Hello,

I checked on -DEV env, on the submission page, for "on this site" , "on your own" and the "source code" submission page, and the text is now there, the only mention is that instead of 200 mb, it's 209.7 mb

Thank you!

alexandruschek avatar Oct 14 '24 14:10 alexandruschek

Hello,

I checked again on both ENVs, on -DEV the filesize is 200, but on stage is still 209.

DEV: image STAGE: image

Thank you!

alexandruschek avatar Oct 17 '24 06:10 alexandruschek

Message at upload of source code has been modified too at 200MB - on dev. Stage is still with the old numbers , probably this didn't make the stage tag.

matches the message at upload

ioanarusiczki avatar Oct 17 '24 09:10 ioanarusiczki

This is also on -stage now.

ioanarusiczki avatar Oct 17 '24 11:10 ioanarusiczki