addons-server icon indicating copy to clipboard operation
addons-server copied to clipboard

Re-organize docker compose files to use includes pattern

Open KevinMind opened this issue 9 months ago • 0 comments

Relates to: https://mozilla-hub.atlassian.net/browse/ADDSRV-720 Partially fulfills: https://github.com/mozilla/addons-server/pull/22182

Depends on:

  • https://github.com/mozilla/addons-server/pull/22211
  • https://github.com/mozilla/addons-server/pull/22206
  • https://github.com/mozilla/addons-server/pull/22195

Description

  • split base config from "addons"
  • create additional configs for:
  1. mounting the deps from host
  2. mounting the source code from host
  3. block pulling in ci
  4. building the image with bake
  • add makefile commands to orchestrate locally and in CI

Context

Previously, we had used the -f argument to override or add additional configurations to docker compose. I've moved to using the newer includes pattern which allows us to split our compose file into more modular blocks that can be included in final compose files.

This is a bit more verbose but given we need our compose config to work in multiple different environments with different constraints it makes understanding what a compose file is "composed" of.

Testing

KevinMind avatar May 06 '24 08:05 KevinMind