addons-linter icon indicating copy to clipboard operation
addons-linter copied to clipboard

Bump os-locale (add support for ESM dependencies)

Open fregante opened this issue 1 year ago • 1 comments

  • Picks up https://github.com/mozilla/addons-linter/pull/4989
  • Partially includes https://github.com/mozilla/addons-linter/pull/5414
    • because Jest requires it to actually read transformIgnorePatterns correctly

os-locale v6 has huge savings

v6

Screenshot 6

v7

Screenshot 7

fregante avatar Aug 23 '24 08:08 fregante

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.77%. Comparing base (348829c) to head (b4543d5). Report is 57 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5415   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files          51       51           
  Lines        2855     2855           
  Branches      867      867           
=======================================
  Hits         2820     2820           
  Misses         35       35           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 23 '24 12:08 codecov[bot]

Ping

fregante avatar Nov 11 '24 10:11 fregante

@fregante sorry to let you wait on this. The fact that we're essentially adding ESM support here is a bit scary to me (not necessarily a bad thing but not as straightforward as a simple version bump). We'll be looking into converting addons-linter to ESM before the end of the year (though that might not happen for various reasons...). In the meantime, we should probably look at this PR.

willdurand avatar Nov 18 '24 12:11 willdurand

"Adding ESM support" means bundling those ESM dependencies, with an explicit list of dependencies to bundle. No ESM dependency will actually be exposed to npm users.

Once you do publish ESM, you can just drop/revert that part of the config and it will continue working.

fregante avatar Nov 18 '24 12:11 fregante

Yeah, indeed.

willdurand avatar Nov 18 '24 12:11 willdurand

Thanks for looking into this @fregante . I'm closing this PR because rather than updating the dependency, we decided to drop the dependency altogether in https://github.com/mozilla/addons-linter/pull/5520, because the feature that depended on it was not used (#5521).

Rob--W avatar Feb 13 '25 13:02 Rob--W

What about the other ESM dependencies? The setup can work for other dependencies.

fregante avatar Feb 13 '25 14:02 fregante