addons-linter icon indicating copy to clipboard operation
addons-linter copied to clipboard

6.28.0 deprecation warnings

Open wagnerand opened this issue 1 year ago • 3 comments

npm warn deprecated [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported

inflight

├─┬ [email protected]
│ └─┬ [email protected]
│   └─┬ [email protected]
│     └─┬ [email protected]
│       └─┬ [email protected]
│         └─┬ [email protected]
│           └── **[email protected]**

rimraf

├─┬ [email protected]
│ └─┬ [email protected]
│   └─┬ [email protected]
│     └─┬ [email protected]
│       └── **[email protected]**

glob

├─┬ [email protected]
│ └─┬ [email protected]
│   └─┬ [email protected]
│     └─┬ [email protected]
│       └─┬ [email protected]
│         └── **[email protected]**

wagnerand avatar May 28 '24 19:05 wagnerand

Updating to eslint@9 would resolve all warnings, but it seems we never received a PR for that. Why not? Can/should we update?

wagnerand avatar May 28 '24 19:05 wagnerand

A couple of plugins are would need to be updated to support eslint@9:

  • eslint-plugin-no-unsanitized, blocked on https://github.com/mozilla/eslint-plugin-no-unsanitized/issues/241
  • eslint-config-amo, blocked on https://github.com/mozilla/eslint-config-amo/issues/567

wagnerand avatar May 28 '24 19:05 wagnerand

[email protected] is still having these deprecation warnings. See https://github.com/mozilla/web-ext/issues/3398#issuecomment-2833429551 for an example of output.

Overview (I passed all listed deprecated dependencies that appears when running npm i to npm list):

$ npm list [email protected] [email protected] [email protected] @humanwhocodes/[email protected] @humanwhocodes/[email protected] [email protected] --depth=10
└─┬ [email protected]
  └─┬ [email protected]
    ├─┬ [email protected]
    │ └── [email protected] deduped
    └─┬ [email protected]
      ├─┬ @eslint-community/[email protected]
      │ └── [email protected] deduped
      ├─┬ @humanwhocodes/[email protected]
      │ └── @humanwhocodes/[email protected]
      └─┬ [email protected]
        └─┬ [email protected]
          └─┬ [email protected]
            └─┬ [email protected]
              └── [email protected]

Rob--W avatar Apr 27 '25 12:04 Rob--W

Updating to eslint@9 would resolve all warnings,

eslint@10 is due to come out in a few month and there are a few breaking changes (which should make v10 slimmer). It might be worthwhile to aim directly for v10.

See also: What's coming in ESLint v10.0.0

erosman avatar Oct 25 '25 14:10 erosman

hopefully https://github.com/mozilla/addons-linter/pull/5841 will help

willdurand avatar Nov 13 '25 12:11 willdurand

I checked locally that there are no more deprecation warnings

% rm -rf node_modules
% npm install --loglevel=warn

added 877 packages, and audited 878 packages in 2s

196 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

% npm ls | grep deprecated
% npm audit
found 0 vulnerabilities

wagnerand-moz avatar Nov 13 '25 12:11 wagnerand-moz