addons-linter icon indicating copy to clipboard operation
addons-linter copied to clipboard

Add a link to MDN doc page as part of the description of MANIFEST_INSTALL_ORIGINS error message

Open diox opened this issue 3 years ago • 1 comments

As part of https://github.com/mozilla/addons-linter/issues/4061 we're going to add more specific error messages for errors related to install_origins. Ideally we'd have a link to a MDN page, but that MDN page doesn't exist yet and needs to be created first. Once it exists, we can go back and edit the description or MANIFEST_INSTALL_ORIGINS to include the link to it.

diox avatar Dec 06 '21 11:12 diox

This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions.

stale[bot] avatar Jul 31 '22 12:07 stale[bot]

@diox is this issue still relevant?

willdurand avatar Nov 02 '22 08:11 willdurand

Let's close it for now.

diox avatar Nov 02 '22 11:11 diox

There is a MDN link in validation error messages related to install_origins pointing to https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/install_origins, which is not available yet. image

@willdurand in https://github.com/mozilla/addons-linter/pull/4591#issuecomment-1315393328 you're mentioning that this error message is not displayed at the moment, but I'm not sure what you mean by that. I can upload an extension that uses the install_origins property on prod and see the error message for invalid install origins. Maybe you mean that this property is not actively used at the moment, so running into this error is highly unlikely?

AlexandraMoga avatar Nov 16 '22 11:11 AlexandraMoga

I can upload an extension that uses the install_origins property on prod and see the error message for invalid install origins. Maybe you mean that this property is not actively used at the moment, so running into this error is highly unlikely?

Why would you do that? ;-) In short, this top-level manifest key should not be used, FF will actually ignore it very soon, see https://bugzilla.mozilla.org/show_bug.cgi?id=1800703. That's why users should never see this error message.

And yeah, the MDN page is not published for the same reason. The short url is valid, still (and if we ever document install_origins, it will point to the right page on MDN).

willdurand avatar Nov 16 '22 11:11 willdurand