addons-linter icon indicating copy to clipboard operation
addons-linter copied to clipboard
verified publisher icon mozilla

Omit linting warnings and errors related to manifest_version 3 extension when the addons-linter max allowed manifest version is set to 2

Open rpl opened this issue 4 years ago • 2 comments

As a follow up for the changes we introduced for #3721, we agreed that:

  • when addons-linter is configured to only allow manifest version 2 extensions (which is currently the default behavior while the --max-manifest-version cli option value is set to 2)
  • we would like to omit the validation errors related to manifest properties only allowed to manifest_version 3 extensions

(e.g. see https://github.com/mozilla/addons-linter/issues/3721#issuecomment-841232347 to see what validation messages are being currently produced for a manifest_version 2 extension with a typo in the background manifest property).

rpl avatar May 28 '21 11:05 rpl

Closing as wontfix, we will reconsider as soon as we would have determined how the feature supported by this Firefox-specific MV2 API would be introduced in the set of APIs that are going to be available to MV3 extensions in Firefox.

rpl avatar Jun 14 '22 14:06 rpl

:facepalm: This wasn't the issue that https://github.com/mozilla/addons-linter/issues/3737#issuecomment-1155293600 refers to, and so I'm reopening and adding back the "maybe good first bug" label.

rpl avatar Jun 14 '22 14:06 rpl

@rpl is this still necessary?

willdurand avatar Nov 01 '22 20:11 willdurand

Probably fixed by https://github.com/mozilla/addons-linter/pull/4397

willdurand avatar Nov 03 '22 11:11 willdurand