addons-frontend
addons-frontend copied to clipboard
mozilla
Create a 404 page specific to missing addons and update copy on generic 404 page
The page you are referencing is our standard 404 page. That is, we display it in many different contexts, not just when an add-on isn't found, so I'm not sure it makes sense to change it the way you describe in the doc.
It may be possible to define a special 404 page that gets used when we know we're showing it specifically because an add-on is not found, but that would be a not insignificant amount of work.
Fwiw, I requested comment-access to the doc to give the exact same feedback :)
Hmm okay thanks.
@jvillalobos thoughts on handling this case? Apologies - not sure where I got the impression this wasn't an all encompassing 404 page.
I have requested edit access to the doc as without it I cannot see what changes were introduced. For now, the doc still looks like it's suggesting a different message for instances where we know an add-on has been removed, but my earlier comments indicated that that is not something we currently do, and would be a significant code change.
If the requirements have changed to just be a change in wording to the existing 404 page, can the document be updated to reflect that? Or, even better, can the requested change be added as a comment to this issue?
The requested change is the we do have two different pages, one for listed add-ons that aren't currently visible and another one for all remaining 404 cases.
The requested change is the we do have two different pages, one for listed add-ons that aren't currently visible and another one for all remaining 404 cases.
Ok, thanks @jvillalobos. That makes this a much bigger change. I will update the description of this issue to explain that it's about doing two things.
Hello @bobsilverberg. I would like to work on this issue. Can I have a bit more insight about this? Thank you.
@bhushan-borole I'm not sure that this is a good candidate for a contributor. Those issues tend to be labelled with contrib: good first bug and contrib: welcome.
@bobsilverberg I want to give a try on this one. We already have a 404 page, so I think I can create tone 404 for missing add-ons, and then we update the routes.
I really want to contribute to the project, but I can't find a good first issue. I believe this one is a good start for me.
Thanks.
@PedroFonsecaDEV Thank you for your interest. As discussed above , this really isn't a good issue for a contributor, and particularly not as a first bug. There are complexities here that might even involve having to coordinate changes on the server, so it's really not a good candidate.
@bobsilverberg Could you point me towards an issue that I can work on?
Hi @PedroFonsecaDEV! Any issue labeled contrib: good first bug in our repositories that isn't actively being worked on by someone else is a good starting issue. :) You can check the current list here.
We try to update the list of good-first-issues every two weeks, but occasionally there are no available issues to work on. If that happens, you might want to check out Codetribute for good first issues in other Mozilla projects.
Happy bug fixing!
This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions.