addons-frontend icon indicating copy to clipboard operation
addons-frontend copied to clipboard

Install the react-router-dom-v5-compat package

Open bobsilverberg opened this issue 1 year ago • 2 comments

Fixes #11860

We should hold off merging this until https://github.com/mozilla/addons-frontend/issues/11847 is verified on dev, so we're not stuck trying to figure what caused a problem, if one is found.

bobsilverberg avatar Sep 28 '22 14:09 bobsilverberg

Codecov Report

Base: 98.48% // Head: 98.48% // No change to project coverage :thumbsup:

Coverage data is based on head (407085c) compared to base (59c2129). Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11861   +/-   ##
=======================================
  Coverage   98.48%   98.48%           
=======================================
  Files         254      254           
  Lines        9967     9967           
  Branches     3002     3002           
=======================================
  Hits         9816     9816           
  Misses        143      143           
  Partials        8        8           
Impacted Files Coverage Δ
src/amo/components/Root/index.js 85.71% <50.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 28 '22 14:09 codecov[bot]

I'm not sure we even want to do this. I was unable to get the compat package to actually work with a v6 route, so at this point it's not doing anything for us. I will leave this here for now.

bobsilverberg avatar Oct 04 '22 17:10 bobsilverberg

I'm going to close this as well. If we do end up implementing this compat package it's going to look a bit different.

bobsilverberg avatar Oct 27 '22 12:10 bobsilverberg