addons-frontend
addons-frontend copied to clipboard
Install the react-router-dom-v5-compat package
Fixes #11860
We should hold off merging this until https://github.com/mozilla/addons-frontend/issues/11847 is verified on dev, so we're not stuck trying to figure what caused a problem, if one is found.
Codecov Report
Base: 98.48% // Head: 98.48% // No change to project coverage :thumbsup:
Coverage data is based on head (
407085c
) compared to base (59c2129
). Patch coverage: 50.00% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## master #11861 +/- ##
=======================================
Coverage 98.48% 98.48%
=======================================
Files 254 254
Lines 9967 9967
Branches 3002 3002
=======================================
Hits 9816 9816
Misses 143 143
Partials 8 8
Impacted Files | Coverage Δ | |
---|---|---|
src/amo/components/Root/index.js | 85.71% <50.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I'm not sure we even want to do this. I was unable to get the compat package to actually work with a v6 route, so at this point it's not doing anything for us. I will leave this here for now.
I'm going to close this as well. If we do end up implementing this compat package it's going to look a bit different.