addons-code-manager icon indicating copy to clipboard operation
addons-code-manager copied to clipboard

Published 20 hours ago • verified publisher icon mozilla

Keyboard navigation between diffs is not working properly while viewing a trimmed file

Open AlexandraMoga opened this issue 5 years ago • 1 comments

Similar to #967 but for diffs

Describe the problem and steps to reproduce it:

  1. Load the following compare page: https://code.addons-dev.allizom.org/en-US/compare/1865/versions/1688304...1688388/?path=lib%2Fadblockplus.js
  2. Press n on your keyboard to jump to the next changed diff
  3. Press n again and notice the line number displayed in the URL

What happened?

The URL shows the next diff with changes while the UI doesn't update

What did you expect to happen?

The UI should display the correct diff when using keyboard navigation while viewing a trimmed file

Anything else we should know?

  • if you opt to see the original file, the issue will not reproduce

2019-07-24_17-05-05

┆Issue is synchronized with this Jira Task

AlexandraMoga avatar Jul 24 '19 14:07 AlexandraMoga

Thanks for filing. This is similar to https://github.com/mozilla/addons-code-manager/issues/967 but different.

kumar303 avatar Jul 24 '19 15:07 kumar303