addons-code-manager icon indicating copy to clipboard operation
addons-code-manager copied to clipboard

Render historic comments for files, inline

Open kumar303 opened this issue 5 years ago • 2 comments

Describe the problem and steps to reproduce it:

Consider this imaginary UI flow:

  • Sign in as a reviewer
  • Open a version compare page (or browse page)
  • Before entering comments, try to look at a previous version to see what comments were left last time
  • Begin entering comments for the new version

What happened?

n/a

What did you expect to happen?

The older comments should be displayed when viewing an already reviewed version

Anything else we should know?

This depends on https://github.com/mozilla/addons/issues/6647

This is similar to viewing draft comments: https://github.com/mozilla/addons-code-manager/issues/713

┆Issue is synchronized with this Jira Task

kumar303 avatar May 08 '19 22:05 kumar303

With mozilla/addons#6647 being fixed, I'm going to remove the needs: api label for now. Let me know if you need anything specific on top of that.

EnTeQuAk avatar Jul 24 '19 14:07 EnTeQuAk

We do have an API to list comments but I think it needs some tweaks to support this issue. See https://github.com/mozilla/addons/issues/7118

kumar303 avatar Nov 12 '19 19:11 kumar303