addons-code-manager icon indicating copy to clipboard operation
addons-code-manager copied to clipboard

Add a canned response at a specific line of a text file

Open kumar303 opened this issue 6 years ago • 3 comments

User story:

As a code reviewer, I want to be able to enter canned responses for specific code lines in the file viewer.

Similar to writing review comments (https://github.com/mozilla/addons-code-manager/issues/112), this is about pre-selecting a "canned" response, i.e. a pre-written review comment. This is important because the pre-written comment will contain carefully worded language and maybe even links to help the developer solve the problem.

The suggested UI flow per meeting notes is roughly this:

  • click on a line of a file to begin entering a comment
  • when presented with a list of canned responses, select one
  • press save

┆Issue is synchronized with this Jira Task

kumar303 avatar Feb 01 '19 21:02 kumar303

this is about pre-selecting a "canned" response

Where do canned replies come from? The API? Is it per-reviewer? Cross-reviewers? Can users manager those replies?

willdurand avatar Feb 22 '19 18:02 willdurand

Where do canned replies come from? The API? Is it per-reviewer? Cross-reviewers? Can users manager those replies?

They will be exposed through an API: https://github.com/mozilla/addons/issues/6596

EnTeQuAk avatar Apr 30 '19 13:04 EnTeQuAk

I removed the needs: api label, as the related API has been implemented since mid-may.

Please do let me know if you need any more information or if the API isn't sufficient.

EnTeQuAk avatar Sep 17 '19 13:09 EnTeQuAk