activity-stream icon indicating copy to clipboard operation
activity-stream copied to clipboard

Published 20 hours ago • verified publisher icon mozilla

Bug 1575889 - Fixing a bit about how we flip the pref from AS to DS

Open ScottDowne opened this issue 5 years ago • 6 comments

To test:

  1. Set browser.newtabpage.activity-stream.discoverystream.enabled to false
  2. Open a new tab, keep it open.
  3. Flip browser.newtabpage.activity-stream.discoverystream.enabled from false to true
  4. Look at the tab you opened, expected, it shouldn't have changed.
  5. Open a new tab
  6. expected, it should be different

ScottDowne avatar Aug 22 '19 16:08 ScottDowne

Will strange things happen if the config doesn't exist in the feed and someone tries to interact with the "stale" page? E.g., scrolls down to a spoc which then tries to trigger an impression ?

Mardak avatar Aug 22 '19 16:08 Mardak

Taskcluster failed but I think it's not because of your code and related to: https://bugzilla.mozilla.org/show_bug.cgi?id=1575774

gvn avatar Aug 22 '19 18:08 gvn

With a fresh profile I'm not seeing anything different between the tabs at step 6.

gvn avatar Aug 22 '19 18:08 gvn

@Mardak Should be good. I tested a bunch of stuff to be sure.

@gvn I just tested it with a new profile and it worked fine. I think maybe we can test this over zoom in a bit?

ScottDowne avatar Aug 23 '19 18:08 ScottDowne

Found some bugs in pref change acting like a startup in a few cases, causing visual update to the open tabs.

Todo for me.

  1. File a new bug.
  2. Force push to fix taskcluster.

ScottDowne avatar Aug 26 '19 21:08 ScottDowne

Current test steps are working 👍

gvn avatar Aug 28 '19 17:08 gvn