mozilla-services
Cleanup helm charts
We currently redefine a number of env variables twice in our helm charts (e.g. SYNC_DATABASE_POOL_MAX_SIZE), for backwards compatibility with the pre-crate reorganization work that split the settings up into tiered generic syncserver/syncstorage specific/tokenserver specific settings.
This change was a long time ago now so these duplicate vars are no longer needed. This applies to both the syncstorage and tokenserver configmaps.
There’s probably some further cleanup that could be addressed (maybe we can log separate issues for those as we work on this change).
┆Issue is synchronized with this Jira Task
➤ Philip Jenvey commented:
We can also remove SENTRY_ENVIRONMENT at some point after https://mozilla-hub.atlassian.net/browse/STOR-90 ( https://mozilla-hub.atlassian.net/browse/STOR-90|smart-link ) lands and bakes long enough to where we wouldn’t need to rollback to a version requiring the old var.