syncstorage-rs icon indicating copy to clipboard operation
syncstorage-rs copied to clipboard

Flip feature flag for using Rust implementation of token generation and oauth JWT verification

Open data-sync-user opened this issue 9 months ago • 2 comments

We landed support for having the Rust code directly verify the access token JWT, and directly generate the HAWK tokens for syncstorage.

We landed it so it only works if the old python implementation is feature flagged off.

This ticket tracks enabling the feature flag in production for tokenserver so that the Rust code is enabled.

┆Issue is synchronized with this Jira Task

data-sync-user avatar Mar 28 '25 15:03 data-sync-user

➤ Philip Jenvey commented:

The original Python implementation of the verifier is currently set as the default via a rust compile time feature flag py_verifier: disabling that feature flag enables the Rust version.

We might want to consider switching from a compile time flag to a configuration setting to make it easier to test on a staging/production environment, particularly for a canary only setup.

data-sync-user avatar Mar 28 '25 15:03 data-sync-user

We might want to consider switching from a compile time flag to a configuration setting to make it easier to test on a staging/production environment, particularly for a canary only setup.

If you do that, you doom everyone to having to install and link to a Python interpreter, in order to never use it. If the direction of progress is to remove the dependency on Python, it would not be a good move to make it mandatory.

There are people who use this software who don't work for Mozilla.

kyz avatar Jun 09 '25 00:06 kyz