mozilla-pipeline-schemas icon indicating copy to clipboard operation
mozilla-pipeline-schemas copied to clipboard

Published 20 hours ago • verified publisher icon mozilla-services

Ensure `version` property is required when present in legacy telemetry

Open sean-rose opened this issue 1 year ago • 1 comments

Checklist for reviewer:

  • [ ] Commits should reference a bug or github issue, if relevant (if a bug is referenced, the pull request should include the bug number in the title)
  • [ ] If adding a new field, the field should have a description (see #576 for an example)
  • [ ] If coming from a fork, run integration tests: ./.github/push-to-trigger-integration <username>:<branchname>

For glean changes:

  • [ ] Update templates/include/glean/CHANGELOG.md

For modifications to schemas in restricted namespaces (see CODEOWNERS):

sean-rose avatar May 03 '24 19:05 sean-rose

especially if it's needed for the other PR

It isn't needed for #811 as I've already made adjustments there to more gracefully handle version properties that might be configured to allow nulls (though that should never be the case in the actual data due to how ingestion works as you've pointed out).

So this is more about making the affected schemas more reflective of reality, consistent with the other legacy schemas, and enforcing that consistency for legacy schemas going forward.

sean-rose avatar May 03 '24 21:05 sean-rose