mozilla-pipeline-schemas icon indicating copy to clipboard operation
mozilla-pipeline-schemas copied to clipboard

Don't add default dependencies if none exist

Open fbertsch opened this issue 4 years ago • 2 comments

Currently, we add the default Glean dependency if none exist. However this runs contrary to expectations; we now have tables for e.g. firefox-ios with Android-specific fields.

We should instead allow there to be no dependencies.

This change will be backwards-incompatible with existing tables, since it will drop fields. We should be able to deal with this by using a SELECT * EXCEPT on the existing data. Deploying this change will require coordination with ops, as described in this bug.

cc @mdboom @Dexterp37

fbertsch avatar Aug 10 '20 13:08 fbertsch

Ouch :D

Dexterp37 avatar Aug 10 '20 14:08 Dexterp37

Since we're simply dropping columns, we could manually remove these columns from the views instead. The downside being we need to keep the columns during dependency generation (in some way), but the upside around deploy may be worth it.

fbertsch avatar Aug 10 '20 14:08 fbertsch