android-sync icon indicating copy to clipboard operation
android-sync copied to clipboard

Bug 814750 - execution queue

Open ncalexan opened this issue 12 years ago • 0 comments

This uses an execution service rather than the existing nested stack for executing global sync stages.

The final two commits are there for comments only -- they show what a stage factory might look like. We could go this direction, or not -- I'm not particularly tied to it, and made earlier changes (construction flow) that make the factory pattern less appealing.

One reason to use the execution service was to "explicitly release" stages that had been executed so that we could GC them. Two comments:

  • stages can be executed multiple times (reset, wipe, execute), including possibly after a restart, so this is hard to do without calling prepareStages multiple times, at which point we should just use the factory.
  • stages actually use very little memory, so GCing them is mostly for hygiene and clarity of lifecycles; lifecycle seems better conveyed by the factory pattern.

Thoughts?

ncalexan avatar Jan 30 '13 20:01 ncalexan