mozilla-vpn-client icon indicating copy to clipboard operation
mozilla-vpn-client copied to clipboard

No ticket: Fix QML console warnings

Open lesleyjanenorton opened this issue 10 months ago • 1 comments

Description

While investigating what has ruffled our Android build's proverbial feathers in v2.21, I noticed the console complaining loudly over every appearance of an MZSettingsToggle {}. This PR fixes Warning: qrc:/nebula/components/MZSettingsToggle.qml:172:17: QML MZUIStates: The current style does not support customization of this control (property: "indicator" item: MZUIStates_QMLTYPE_9(0x60000330ebc0, parent=0x0, geometry=0,0 0x0, z=-1)). Please customize a non-native style (such as Basic, Fusion, Material, etc). and Warning: qrc:/nebula/components/MZSettingsToggle.qml:24:5: Unable to assign [undefined] to int (MZSettingsToggle.qml:24).

🪐 UPDATE: After more clicking around I realized these warnings are triggered other input components as well. Second commit addresses these as well.

Related Qt bug: https://bugreports.qt.io/browse/QTBUG-109438

Checklist

  • [ ] My code follows the style guidelines for this project
  • [ ] I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • [ ] I have performed a self review of my own code
  • [ ] I have commented my code PARTICULARLY in hard to understand areas
  • [ ] I have added thorough tests where needed

lesleyjanenorton avatar Apr 22 '24 20:04 lesleyjanenorton

@mcleinman That is a good call out but also a really strange one because I'm using 6.6 for local mac builds and still seeing this. Will do some more digging in their bug list to see if there is any mention of a regression in 6.6, etc.

lesleyjanenorton avatar May 13 '24 22:05 lesleyjanenorton

The QTBug seems to be Fixed in Qt 6.6.0+ which we are moving to. Currently closing some stale pr's :) - Please re-open if needed.

strseb avatar Jun 07 '24 17:06 strseb