mozilla-vpn-client
mozilla-vpn-client copied to clipboard
mozilla-mobile
Buttons in "Subscription Expiring" message do not work
Mozilla VPN affected versions:
- 2.15.0
Platform tested:
- all;
Prerequisites:
- Have the client opened;
- Have an account whose subscription is expiring within the next 7 days (with auto-renew turned off)
Steps to reproduce:
- Go to the messages screen
- Click the “Your subscription is ending soon” message
- Try clicking either of the CTA’s
Expected results:
- Manage account takes them to the correct location based on where the subscription was purchased:
- Web:
- Apple: https://apps.apple.com/account/subscriptions or the system subscription settings on iOS
- Google: https://play.google.com/store/account/subscriptions (or probably the system subscription settings on Android, if they have that 🤷♂️)
- Contact support takes them to
Actual results:
- Manage account” and “Contact support” buttons do nothing
┆Issue is synchronized with this Jira Bug ┆Reporter: Matt Lichtenstein
➤ Matt Lichtenstein commented:
Santiago Andrigo Where are these buttons supposed to link to? It looks like when they were originally implemented, they were both opening to to web urls
Manage accounts was going to: https://accounts.firefox.com/signin ( https://accounts.firefox.com/[email protected] )
Contact support was linking… nowhere (Beatriz Rizental Machado maybe I am wrong here?) - should this be linking to one of the web forms (http://subscriptions.firefox.com ( http://subscriptions.firefox.com/ ) or https://support.mozilla.org/en-US/products/firefox-private-network-vpn+ ( https://support.mozilla.org/en-US/products/firefox-private-network-vpn+|smart-link ) - which both have different support forms), or to the in-app support page?
➤ Santiago Andrigo commented:
Matt Lichtenstein
- For the first CTA: Let’s send them to https://subscriptions.firefox.com/subscriptions ( https://subscriptions.firefox.com/subscriptions ) please.
- For the second CTA: Let’s send them to the in-app Contact Support page please.
➤ Matt Lichtenstein commented:
Santiago Andrigo As far as I can tell (Andrea Marchesini can correct me if I am wrong) we don’t currently have a way to deep link to the contact support form, so there would need to be some changes to the client. Possibly significant changes that will likely delay the RC.
Do we want to:
a) implement these changes so we can deep link
b) deep link to the “get help” page instead (this is already supported, but we’d probably want to change the CTA string in the message from “contact support” to “get help”… is it too late for this due to translations?)
c) link out to one of the web support forms mentioned in my previous comment
d) disable this message for 2.15, and do option a) or b) for 2.16
➤ Santiago Andrigo commented:
This is not important enough to allocate further effort. Seems like (c) is a good path forward.
➤ Matt Lichtenstein commented:
Santiago Andrigo regarding this
{quote}For the first CTA: Let’s send them to https://subscriptions.firefox.com/subscriptions ( https://subscriptions.firefox.com/subscriptions ) please.{quote}
It turns out we already have the logic to send them to either FxA, apple subscriptions, or google subscriptions based on there subscription type, so unless there are any objections, I will implement it so that the CTA takes them to where the subscription was purchased from
➤ Santiago Andrigo commented:
Ah, that’s great! I had completely forgotten about the mobile subs, thanks for catching that.
➤ Valentina Virlics commented:
Verified this on across platforms on the last 2.15 builds.
The following are happening:
- The “Manage account“ button redirects to Subscriptions page - https://payments-stage.fxa.nonprod.cloudops.mozgcp.net/subscriptions ( https://payments-stage.fxa.nonprod.cloudops.mozgcp.net/subscriptions ) - I would expect, based on button label to redirect to FxA Settings page;
- The “Contact support“ button redirects to support - https://accounts.stage.mozaws.net/support ( https://accounts.stage.mozaws.net/support )
- [mobile] - can only be checked on iOS (the message is not received on Android while having an canceled IAP subscription)
- While clicking the “Manage account” button user is redirected to App Store, but we cannot check if the correct link because of stage restrictions;
- While clicking the “Contact Support“ button the app crashes. (attaching logs) - only reproducing on iPad Air 2 - iOS 15.7.1 and not reproducing on iPhone 11 - iOS 16;
Matt Lichtenstein Please let us know if we should track the crash separately.
[^mozillavpn (3).txt]
If the crash is tracked here, we should reopen this ticket.
➤ Valentina Virlics commented:
Matt Lichtenstein could you please check out our questions? Thank you!
➤ Matt Lichtenstein commented:
Valentina Virlics I’ve summarized the current issues with the subscription expiring message here ( https://mozilla-hub.atlassian.net/browse/VPN-2542?focusedCommentId=677180 ) - but I have not done any investigation into the issues. Maybe we reopen the original story? what do you think?
➤ Santiago Andrigo commented:
Note - this code is on 2.15 and should be QA’d, but it’s for a feature that is disabled on 2.15. Hence, this is not a 2.15 blocker.
➤ Valentina Virlics commented:
Santiago Andrigo We cannot verify this on 2.15, as the feature is disabled. Should we remove the fixVersion or what would be the proper approach for this ticket?
➤ Santiago Andrigo commented:
Switching to Blocked.
Matt Lichtenstein Lesley Norton As per comments in this: https://mozilla-hub.atlassian.net/browse/VPN-2542 ( https://mozilla-hub.atlassian.net/browse/VPN-2542|smart-link ) , should we re-enable this in main so that QA can test if this works in 2.17?
If so, can we create a ticket for this re-enablement and relate it to this ticket as ‘Blocking’?
➤ Matt Lichtenstein commented:
Santiago Andrigo I think we should re-enable it and test it whenever we prioritize releasing it, meaning all the other bugs that come with it are prioritized at the same time. Otherwise we are going to re-enable it just to disable it again if it doesn’t go out by the time we cut the next RC’s
➤ Lesley Norton commented:
Santiago Andrigo Done with caveat: I created https://mozilla-hub.atlassian.net/browse/VPN-5006 ( https://mozilla-hub.atlassian.net/browse/VPN-5006|smart-link ) to enable the message, but on stage for now only.
➤ Santiago Andrigo commented:
Matt Lichtenstein Agreed, but afaik all issues have been resolved or we have decided to go forward without them:
- Message not being received for IAP subscriptions ---> As per Valentina’s comment this seems to have already been fixed in iOS, but we are unsure about Android. We need the feature to be enabled to verify. But at any rate, it wouldn’t be a blocker to release to non-IAP. IAP is a small percentage of our total subscriptions.
- “Remote service error” when accessing the “Profile” view from the client while on an FxA account with the 8-day staging test subscription ---> Only affects Staging on 8-day plans. We can move forward.
- “Contact support” button crashes the app on iPad Air 2 ---> We should have a ticket for this. If it’s specific to the iPad Air 2, then I think it’s not a blocker either.
➤ Matt Lichtenstein commented:
Santiago Andrigo - in that case, do you want to enable it for 2.16?
➤ Valentina Virlics commented:
Santiago Andrigo for <“Contact support” button crashes the app on iPad Air 2 ---> We should have a ticket for this. If it’s specific to the iPad Air 2, then I think it’s not a blocker either.“> - we will log a tracking ticket once the feature is re-enabled and I can still see it happening. Thanks!