mozilla-vpn-client
mozilla-vpn-client copied to clipboard
Remove bundle upsell message and UI
Description
This PR removes...
- The privacy bundle in-app message
- The upgrade paths in ViewSubscriptionManagement and related tidbits
Reference
https://mozilla.slack.com/archives/C0291CWG53K/p1663716976010969
Checklist
- [ ] My code follows the style guidelines for this project
- [ ] I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
- [ ] I have performed a self review of my own code
- [ ] I have commented my code PARTICULARLY in hard to understand areas
- [ ] I have added thorough tests where needed
Codecov Report
Base: 27.08% // Head: 70.51% // Increases project coverage by +43.43%
:tada:
Coverage data is based on head (
1b6e73c
) compared to base (6b86681
). Patch has no changes to coverable lines.
Additional details and impacted files
@@ Coverage Diff @@
## main #4513 +/- ##
===========================================
+ Coverage 27.08% 70.51% +43.43%
===========================================
Files 252 255 +3
Lines 14208 15945 +1737
Branches 8081 8070 -11
===========================================
+ Hits 3848 11244 +7396
- Misses 4246 4306 +60
+ Partials 6114 395 -5719
Flag | Coverage Δ | |
---|---|---|
lottie_tests | 56.33% <ø> (+39.43%) |
:arrow_up: |
qml_tests | 7.65% <ø> (+0.02%) |
:arrow_up: |
unit_tests | 71.01% <ø> (+43.06%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
src/constants.h | 75.00% <ø> (+41.66%) |
:arrow_up: |
src/featureslist.h | 0.00% <ø> (ø) |
|
src/models/subscriptiondata.cpp | 0.67% <ø> (+0.67%) |
:arrow_up: |
src/models/subscriptiondata.h | 0.00% <ø> (ø) |
|
src/urlopener.cpp | 43.75% <ø> (+26.23%) |
:arrow_up: |
src/urlopener.h | 100.00% <ø> (ø) |
|
src/signature.cpp | 100.00% <0.00%> (ø) |
|
src/rfc/rfc1918.cpp | 0.00% <0.00%> (ø) |
|
src/rfc/rfc4193.cpp | 0.00% <0.00%> (ø) |
|
src/rfc/rfc5735.cpp | 0.00% <0.00%> (ø) |
|
... and 173 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@bakulf sounds good! Will close this for now in that case.