mozilla-vpn-client
mozilla-vpn-client copied to clipboard
Cross-Plattform Crash Reporting
Description
This PR adds experimental crash reporting support using sentry-native. The feature is disabled by default, only enabled when we're on guardian-stage.
By Crossplattform, i mean osx and windows for now :) - Linux should be straightforward to add, i don't have a vm to test that on right now.
Android & iOS are theoretically supported. We need to either figurre out how to get this into the qmake structure, or port those plattforms finally to cmake again like (#4301)
##Ref https://mozilla-hub.atlassian.net/browse/VPN-2822
Checklist
- [x] My code follows the style guidelines for this project
- [ ] I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question) -> I DID.
- [x] I have performed a self review of my own code
- [x] I have commented my code PARTICULARLY in hard to understand areas
- [ ] I have added thorough tests where needed
Codecov Report
Base: 37.23% // Head: 35.50% // Decreases project coverage by -1.72%
:warning:
Coverage data is based on head (
21664db
) compared to base (46f177c
). Patch coverage: 0.00% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## main #4455 +/- ##
==========================================
- Coverage 37.23% 35.50% -1.73%
==========================================
Files 325 328 +3
Lines 21699 22038 +339
Branches 11739 11832 +93
==========================================
- Hits 8079 7825 -254
- Misses 6080 6778 +698
+ Partials 7540 7435 -105
Flag | Coverage Δ | |
---|---|---|
functional_tests | 22.32% <0.00%> (-5.12%) |
:arrow_down: |
lottie_tests | 23.06% <ø> (ø) |
|
unit_tests | 34.14% <0.00%> (+0.68%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
src/commands/commandui.cpp | 38.61% <ø> (-1.39%) |
:arrow_down: |
src/constants.h | 20.00% <ø> (-2.23%) |
:arrow_down: |
src/featureslist.h | 0.00% <0.00%> (ø) |
|
src/mozillavpn.cpp | 23.58% <0.00%> (-0.65%) |
:arrow_down: |
src/networkrequest.cpp | 17.91% <0.00%> (-0.85%) |
:arrow_down: |
src/networkrequest.h | 0.00% <ø> (-50.00%) |
:arrow_down: |
src/tasks/sentry/tasksentry.cpp | 0.00% <0.00%> (ø) |
|
src/tasks/addonindex/taskaddonindex.h | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
src/captiveportal/captiveportalrequest.h | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
src/tasks/removedevice/taskremovedevice.h | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
... and 113 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.