mozilla-vpn-client icon indicating copy to clipboard operation
mozilla-vpn-client copied to clipboard

Multi hop screen - exit location is overlapped by the new nav bar

Open data-sync-user opened this issue 3 years ago • 4 comments

Mozilla VPN affected versions:

  • 2.10.0 (2.202208310411);

Tested Platforms:

  • All;

Prerequisites:

  • Have a FxA account with an active subscription for Mozilla VPN;
  • Have at least one recent connection pair listed in Multi-hop screen;

Steps to reproduce:

  1. Go to multi-hop location screen;
  2. Expand the multi-hope notes;
  3. Observe the page;

Expected result:

  • The back content of the screen is scrollable and not overlapped by the nav bar.

Actual result:

  • Exit location is overlapped by the nav bar.

!image-20220831-092637.png|width=444,height=836!

┆Issue is synchronized with this Jira Bug ┆author: Valentina Virlics

data-sync-user avatar Sep 14 '22 06:09 data-sync-user

➤ Rebecca Billings commented:

This is expected behavior when the user has expanded content

data-sync-user avatar Sep 14 '22 06:09 data-sync-user

➤ Valentina Virlics commented:

Rebecca Billings Thank you for triaging this.

Just a quick clarification: following the acceptance criteria from feature epic - “Scroll views anywhere in the app that contain content that appears behind the tab bar should have room to be scrolled to so that all content is visible“ - we expect all screen content to be visible at any point.

data-sync-user avatar Sep 14 '22 06:09 data-sync-user

➤ Peter Benvenuto commented:

Rebecca Billings Valentina Virlics if the screen can’t scroll with the card expanded I still think this is a bug and should be fixed to allow padding under.

CC Jessica Valentine

data-sync-user avatar Sep 14 '22 06:09 data-sync-user

➤ Santiago Andrigo commented:

This is bad, but the user can still access the functionality when the card is not expanded, which is the default behavior. Not blocking, but high on my list.

data-sync-user avatar Sep 20 '22 14:09 data-sync-user

➤ Matt Lichtenstein commented:

Would be nice to get a more general fix in via https://mozilla-hub.atlassian.net/browse/VPN-2875 ( https://mozilla-hub.atlassian.net/browse/VPN-2875|smart-link )

data-sync-user avatar Oct 12 '22 14:10 data-sync-user

➤ Bianca Hidecuti commented:

This is also reproducing while having the language set to French for the Advanced DNS settings screen:

  • the error message displayed when entering an invalid DNS is coverd by the nav bar;
  • the custom DNS field is not visible when the VNP is ON.

Attaching a ss as well.

!Screen Shot 2022-10-21 at 15.09.04.png|width=1068,height=965!

data-sync-user avatar Oct 21 '22 12:10 data-sync-user

➤ Valentina Virlics commented:

Verified this as fixed on latest 2.11, across platforms, on multi-hop and DNS screens.

Potsfix ss below.

!ssnav.png|width=668,height=524!

data-sync-user avatar Nov 07 '22 10:11 data-sync-user