mozilla-vpn-client icon indicating copy to clipboard operation
mozilla-vpn-client copied to clipboard

adding multihop functional tests, some optimizations to helper class

Open mozrokafor opened this issue 3 years ago • 1 comments

Description

added multihop connectivity functional tests

Reference

[i.e Jira or Github issue URL](https://mozilla-hub.atlassian.net/browse/PSP-493)

Checklist

  • [x] My code follows the style guidelines for this project
  • [x] I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • [x] I have performed a self review of my own code
  • [x] I have commented my code PARTICULARLY in hard to understand areas
  • [ ] I have added thorough tests where needed

mozrokafor avatar Sep 12 '22 03:09 mozrokafor

Codecov Report

Base: 29.11% // Head: 70.35% // Increases project coverage by +41.24% :tada:

Coverage data is based on head (eda0cbe) compared to base (19fa307). Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4409       +/-   ##
===========================================
+ Coverage   29.11%   70.35%   +41.24%     
===========================================
  Files         227      256       +29     
  Lines       12582    16086     +3504     
  Branches     7120     8131     +1011     
===========================================
+ Hits         3663    11317     +7654     
- Misses       3730     4370      +640     
+ Partials     5189      399     -4790     
Flag Coverage Δ
lottie_tests 56.33% <ø> (ø)
qml_tests 7.55% <ø> (-3.09%) :arrow_down:
unit_tests 70.79% <ø> (+42.92%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/filterproxymodel.h 50.00% <0.00%> (-50.00%) :arrow_down:
src/statusicon.cpp 43.75% <0.00%> (-23.75%) :arrow_down:
src/addons/addonmessage.h 81.81% <0.00%> (-18.19%) :arrow_down:
src/addons/addonpropertylist.cpp 42.42% <0.00%> (-14.72%) :arrow_down:
src/models/feature.h 22.22% <0.00%> (-11.12%) :arrow_down:
src/composer/composer.cpp 47.16% <0.00%> (-5.22%) :arrow_down:
tests/qml/mocmozillavpn.cpp 18.27% <0.00%> (-3.15%) :arrow_down:
src/mozillavpn.h 35.00% <0.00%> (-1.37%) :arrow_down:
src/constants.h 50.00% <0.00%> (ø)
src/controller.h 0.00% <0.00%> (ø)
... and 202 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Sep 12 '22 03:09 codecov-commenter