mozilla-vpn-client icon indicating copy to clipboard operation
mozilla-vpn-client copied to clipboard

Bottom navbar UI

Open MattLichtenstein opened this issue 2 years ago • 1 comments

Description

  • Introduces a Bottom navigation bar to the UI
  • New PR for https://github.com/mozilla-mobile/mozilla-vpn-client/pull/4072 since I messed the last one up

Reference

VPN-2487: Create custom navigation tab bar component

Checklist

  • [ ] My code follows the style guidelines for this project
  • [ ] I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • [ ] I have performed a self review of my own code
  • [ ] I have commented my code PARTICULARLY in hard to understand areas
  • [ ] I have added thorough tests where needed

MattLichtenstein avatar Aug 09 '22 16:08 MattLichtenstein

Codecov Report

Merging #4177 (f955ade) into main (4742832) will increase coverage by 0.12%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4177      +/-   ##
==========================================
+ Coverage   28.82%   28.94%   +0.12%     
==========================================
  Files         217      213       -4     
  Lines       12354    11931     -423     
  Branches     7007     6817     -190     
==========================================
- Hits         3561     3454     -107     
+ Misses       3735     3537     -198     
+ Partials     5058     4940     -118     
Flag Coverage Δ
lottie_tests 56.33% <ø> (ø)
qml_tests 11.05% <ø> (-0.16%) :arrow_down:
unit_tests 27.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/filterproxymodel.cpp 41.66% <0.00%> (-12.02%) :arrow_down:
tests/qml/helper.cpp 79.48% <0.00%> (-9.41%) :arrow_down:
tests/qml/mocmozillavpn.cpp 14.77% <0.00%> (-7.45%) :arrow_down:
src/theme.cpp 42.52% <0.00%> (-3.31%) :arrow_down:
src/closeeventhandler.cpp 20.00% <0.00%> (-2.23%) :arrow_down:
src/loghandler.cpp 41.37% <0.00%> (-1.41%) :arrow_down:
src/theme.h 100.00% <0.00%> (ø)
src/settingslist.h 0.00% <0.00%> (ø)
src/update/webupdater.cpp 0.00% <0.00%> (ø)
tests/qml/moccontroller.cpp 0.00% <0.00%> (ø)
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Aug 09 '22 16:08 codecov-commenter