mozilla-vpn-client icon indicating copy to clipboard operation
mozilla-vpn-client copied to clipboard

Remove The wasm bin from the gh-pages branch

Open strseb opened this issue 2 years ago • 1 comments

This pr's goals is to sunset the gh-pages branch, which takes up quite a bit of space:

-> A: Using an artifact instead of the old gh-pages branch https://github.com/actions/upload-pages-artifact -> B: Not storing the wasm-client in the gh-pages at all. As we have now have wasm builds in taskcluster, i wrote a small "chrome" that can load up the wasm for any branch. -> C: Splitting the gh pages and wasm workflows, as they now do completly diffrent things :) Untitled

strseb avatar Aug 05 '22 14:08 strseb

Codecov Report

Merging #4158 (3713ac7) into main (2a884f6) will increase coverage by 0.32%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4158      +/-   ##
==========================================
+ Coverage   28.82%   29.14%   +0.32%     
==========================================
  Files         217      229      +12     
  Lines       12354    12643     +289     
  Branches     7007     7156     +149     
==========================================
+ Hits         3561     3685     +124     
- Misses       3735     3781      +46     
- Partials     5058     5177     +119     
Flag Coverage Δ
lottie_tests 56.33% <ø> (ø)
qml_tests 11.20% <ø> (-0.01%) :arrow_down:
unit_tests 27.88% <ø> (+0.38%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/addons/addonmessage.cpp 39.39% <0.00%> (-8.11%) :arrow_down:
src/addons/addonguide.cpp 50.00% <0.00%> (-5.56%) :arrow_down:
src/addons/addontutorial.cpp 43.18% <0.00%> (-3.25%) :arrow_down:
src/tutorial/tutorialstep.cpp 31.32% <0.00%> (-0.78%) :arrow_down:
src/settingsholder.cpp 15.78% <0.00%> (-0.14%) :arrow_down:
src/settingslist.h 0.00% <0.00%> (ø)
src/tutorial/tutorial.cpp 35.71% <0.00%> (ø)
src/composer.cpp
src/composerblock.cpp
src/composerblock.h
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Aug 05 '22 14:08 codecov-commenter

does it work for non-github users?

We're using the public api, without auth. That gets you per ip ~ 50 requests / h. No github account reqiured. That's why i'm doing a bit of manual response cache-ing. :)

the artifacts expire after 90 days, is it correct? I guess this is currently acceptable.

Level-3 (main, releases/*) -> 1 year Level-1 (any other) -> 30days

strseb avatar Aug 15 '22 14:08 strseb