VPN-2593 - Provide staging only flag to disable addon signature verification

[brizental]

trafficstars

Description

Opening this as a work in progress to get a bit of early feedback if possible as well as to make the branch available in case I need help debugging this. All builds here, the app runs nicely and signature verification is skipped if the feature is flipped off. However even with that I am unable to see changes made to local addons.

Steps I used for testing:

1. Changed the manifest file of one of the addons. I was changing the contents of the title of a guide.
2. Re-generated addons using python ./scripts/addon/generate_all.py
3. Changed the URL here to point to the right folder in my local server. Note: Just setting the env var was not working.

With this I was able to see when TaskAddonIndex downloaded new stuff and the AddonManager updated itself. Still I saw no changes in the UI. I am not sure what is still missing to see that.

[UPDATE]

Somewhere there seems to be a very persistent cache that I was unable to clean and that is why I was not seeing any of the updates. If I add a completely new guide I am able to see the new guide, but then subsequent changes to this new guide also do not show up afterwards. I think this is something that can be straightened out when writing up the docs for local addon testing (VPN-2596) so I will not consider it a blocking for opening this up for review and merging.

Reference

https://mozilla-hub.atlassian.net/browse/VPN-2593

Checklist

• [ ] My code follows the style guidelines for this project
• [x] I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
• [x] I have performed a self review of my own code
• [x] I have commented my code PARTICULARLY in hard to understand areas
• [x] I have added thorough tests where needed

[codecov-commenter]

Codecov Report

Merging #4151 (bcfb33a) into main (501bb55) will decrease coverage by 8.86%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #4151      +/-   ##
==========================================
- Coverage   28.89%   20.02%   -8.87%     
==========================================
  Files         217       60     -157     
  Lines       12336     3026    -9310     
  Branches     6986     1496    -5490     
==========================================
- Hits         3564      606    -2958     
+ Misses       3735     2202    -1533     
+ Partials     5037      218    -4819     

Flag	Coverage Δ
lottie_tests	56.33% <ø> (ø)
qml_tests	11.04% <0.00%> (-0.17%)	:arrow_down:
unit_tests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/featureslist.h	0.00% <0.00%> (ø)
src/hkdf.h	0.00% <0.00%> (-100.00%)	:arrow_down:
src/models/server.h	0.00% <0.00%> (-100.00%)	:arrow_down:
src/update/updater.h	0.00% <0.00%> (-100.00%)	:arrow_down:
src/models/featuremodel.h	0.00% <0.00%> (-100.00%)	:arrow_down:
src/ipaddress.h	0.00% <0.00%> (-80.00%)	:arrow_down:
src/logger.h	25.00% <0.00%> (-62.50%)	:arrow_down:
src/task.h	0.00% <0.00%> (-60.00%)	:arrow_down:
src/theme.h	50.00% <0.00%> (-50.00%)	:arrow_down:
src/hkdf.cpp	0.00% <0.00%> (-44.45%)	:arrow_down:
... and 188 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[brizental]

Adding @MattLichtenstein for awarenes, @bakulf mentioned you were waiting for this feature :)

[brizental]

Yes, there are test failures on the MacOS tests... tl;dr; If you run the tests with cmake you get no failures not even on the other AddonManager tests that were already failing even priot to this PR. So I will merge this with the failures and file a separate PR for the test fixes where I switch over to cmake.

See also: https://mozilla-hub.atlassian.net/browse/VPN-2664?focusedCommentId=580424