mozilla-vpn-client icon indicating copy to clipboard operation
mozilla-vpn-client copied to clipboard

Number of connected devices not updated on the main screen

Open data-sync-user opened this issue 3 years ago • 1 comments
trafficstars

Affected versions:

  • Mozilla VPN 2.10.0 (2.202208011506);

Tested Platforms:

  • MacOS;

  • iOS;

  • Android;

Prerequisites:

  • Have Mozilla VPN app installed at least on 2 devices;

  • Have a FxA account with an active subscription for Mozilla VPN;

  • Be signed in - Production server - on the first device;

Steps to reproduce:

  1. Sign in with the account from prerequisites on the second device;
  2. Go to the first device and observe the number of connected devices from “My devices” section from the main screen;

Expected result:

  • The number of connected devices has been updated accordingly. “My devices” section displays 2 connected device on the main screen;

Actual result:

  • The number of connected devices has not been updated accordingly. “My devices” section displays only 1 connected device on the main screen;

Notes:

  • If opening the “My devices” screen, the new device is displayed in the "My devices" list. When going back to the main screen, then the number of devices is updated accordingly. 

  • This is not reproducing on Stage server;

  • See the attached video and logs;

┆Issue is synchronized with this Jira Bug ┆author: Bianca Hidecuti

data-sync-user avatar Aug 02 '22 12:08 data-sync-user

➤ Beatriz Rizental Machado commented:

This will be fixed passively by the changes in https://mozilla-hub.atlassian.net/browse/VPN-2254 ( https://mozilla-hub.atlassian.net/browse/VPN-2254|smart-link ) once other message types are implemented. In this case, once a ACCOUNT_UPDATED message (or a similar one) is implemented. It’s worth noting that implementing other push messages is not in the plans for 2.10. We can either add it to the plans or wait for 2.11. The reason why it is not in plans, is because we wanted to ship a single message and monitor it before migrating other features to use push messaging.

data-sync-user avatar Aug 03 '22 08:08 data-sync-user

➤ Lesley Norton commented:

The devices view is now accessed via the settings menu and this information is now only communicated inside the devices view.

data-sync-user avatar Sep 10 '22 00:09 data-sync-user

➤ Bianca Hidecuti commented:

Lesley Norton , this is also happening for the “My devices” screen, even if this has moved inside Settings. If the user stays in the “My devices” screen on a first device, while signing in on a seconde one, the list is not updated until navigating to another screen and coming back (this only happnes on Production server - as the initial issue).

Giving the behavior, do you think we should reopen this issue? Thank you.

data-sync-user avatar Sep 10 '22 00:09 data-sync-user

➤ Lesley Norton commented:

Thank you for the note Bianca, I’ll reopen!

data-sync-user avatar Sep 10 '22 00:09 data-sync-user

➤ Santiago Andrigo commented:

The practical impact of this seems mostly esthetic since it’s about reflecting the total number of devices, and whenever we do a ‘refresh’ action (by switching out of, and back into, a view of devices) it fixes itself. Hence ---> Low priority.

To Bianca Hidecuti ‘s question though – I’m not sure that “live updating” should even be an expectation and I’m inclined to say that so long as the view is refreshed whenever coming into it, then we are good as it is. Lesley Norton thoughts?

data-sync-user avatar Sep 10 '22 00:09 data-sync-user

➤ Bianca Hidecuti commented:

Santiago Andrigo , on staging server, the list is updated without navigating to another screen, so we would expect the same behavior on production server.

data-sync-user avatar Sep 12 '22 09:09 data-sync-user

➤ Matt Lichtenstein commented:

Bianca Hidecuti since this nav item no longer exists on the home screen, is this still a problem (i.e. is the device count in the top-right corner of the “My devices” screen working as intended)?

data-sync-user avatar Jan 23 '23 17:01 data-sync-user

➤ Bianca Hidecuti commented:

Matt Lichtenstein, even though the item no longer exists on the home screen, if the user stays in the “My devices” screen on a first device, while signing in on a seconde one, the list is not updated until navigating to another screen and coming back (this only happnes on Production server).

data-sync-user avatar Jan 25 '23 08:01 data-sync-user

➤ Matt Lichtenstein commented:

Bianca Hidecuti gotcha, okay then I agree that the bug is still relevant

data-sync-user avatar Jan 25 '23 14:01 data-sync-user

➤ Lesley Norton commented:

Because this is working on stage I suspect it is not an issue with the UI. Jeremy Swinarton any thoughts on what is behind the discrepancy with the behavior on stage vs. prod?

data-sync-user avatar Apr 25 '23 02:04 data-sync-user

➤ Lesley Norton commented:

Closed during bug squashing #2. This is an edge case.

data-sync-user avatar May 26 '23 14:05 data-sync-user