Fix QML warnings in ViewSettingsMenu.qml #4118

[lesleyjanenorton]

Description

Fixes ReferenceError: _iconButtonImageSource is not defined (VPNUserProfile.qml:91) and Warning: qrc:/ui/settings/ViewSettingsMenu.qml:48:13: QML VPNUserProfile: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead. (ViewSettingsMenu.qml:48) warnings/errors in ViewSettingsMenu.qml.

Reference

Fixes #4118

Checklist

• [ ] My code follows the style guidelines for this project
• [ ] I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
• [ ] I have performed a self review of my own code
• [ ] I have commented my code PARTICULARLY in hard to understand areas
• [ ] I have added thorough tests where needed

[codecov-commenter]

Codecov Report

Merging #4119 (840232a) into main (3ae9aea) will decrease coverage by 3.98%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4119      +/-   ##
==========================================
- Coverage   31.54%   27.56%   -3.99%     
==========================================
  Files         284      211      -73     
  Lines       17445    11977    -5468     
  Branches     9344     6769    -2575     
==========================================
- Hits         5503     3301    -2202     
+ Misses       5413     3942    -1471     
+ Partials     6529     4734    -1795     

Flag	Coverage Δ
functional_tests	?
lottie_tests	56.33% <ø> (ø)
qml_tests	9.59% <ø> (ø)
unit_tests	26.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/pinghelper.h	0.00% <0.00%> (-100.00%)	:arrow_down:
src/pingsender.h	0.00% <0.00%> (-100.00%)	:arrow_down:
src/signature.cpp	0.00% <0.00%> (-100.00%)	:arrow_down:
src/composerblock.h	0.00% <0.00%> (-100.00%)	:arrow_down:
src/addons/addontutorial.h	0.00% <0.00%> (-100.00%)	:arrow_down:
src/tasks/release/taskrelease.h	0.00% <0.00%> (-100.00%)	:arrow_down:
src/platforms/dummy/dummypingsender.cpp	0.00% <0.00%> (-77.78%)	:arrow_down:
src/pinghelper.cpp	0.00% <0.00%> (-71.43%)	:arrow_down:
src/authenticationinapp/authenticationinapp.h	33.33% <0.00%> (-66.67%)	:arrow_down:
src/controller.h	0.00% <0.00%> (-66.67%)	:arrow_down:
... and 163 more

Help us with your feedback. Take ten seconds to tell us how you rate us.