mozilla-vpn-client icon indicating copy to clipboard operation
mozilla-vpn-client copied to clipboard

Composer

Open bakulf opened this issue 3 years ago • 1 comments

This is a refactoring of the ComposerBlock in multiple files. In this way, adding new types should be easier. We are going to add more block types:

  • external link
  • button
  • label

bakulf avatar Aug 01 '22 14:08 bakulf

Codecov Report

Merging #4115 (8ddb1eb) into main (88d6f1b) will decrease coverage by 38.78%. The diff coverage is 35.48%.

@@             Coverage Diff             @@
##             main    #4115       +/-   ##
===========================================
- Coverage   67.70%   28.92%   -38.79%     
===========================================
  Files         219      227        +8     
  Lines       13697    12471     -1226     
  Branches     6834     7065      +231     
===========================================
- Hits         9274     3607     -5667     
+ Misses       4051     3765      -286     
- Partials      372     5099     +4727     
Flag Coverage Δ
lottie_tests 56.33% <ø> (ø)
qml_tests 11.20% <0.00%> (-0.01%) :arrow_down:
unit_tests 27.62% <35.48%> (-40.45%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/addons/addon.cpp 20.25% <0.00%> (-27.78%) :arrow_down:
src/addons/addon.h 100.00% <ø> (ø)
src/addons/addonguide.cpp 50.00% <0.00%> (-50.00%) :arrow_down:
src/addons/addontutorial.cpp 43.18% <0.00%> (-35.77%) :arrow_down:
src/composer/composer.cpp 52.38% <ø> (ø)
src/composer/composerblocktext.h 0.00% <0.00%> (ø)
src/composer/composerblocktitle.h 0.00% <0.00%> (ø)
src/composer/composerblockunorderedlist.h 0.00% <0.00%> (ø)
src/settingslist.h 0.00% <0.00%> (-45.29%) :arrow_down:
src/tutorial/tutorial.cpp 35.71% <0.00%> (-9.75%) :arrow_down:
... and 163 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Aug 01 '22 19:08 codecov-commenter