mozilla-vpn-client
mozilla-vpn-client copied to clipboard
Globe icon representing VPN state is missing regardless of VPN state
Affected versions:
- 2.10.0 (2.202207270720);
Tested platforms:
- MacOS 11.6;
Prerequisites:
- Have a FxA account with an active subscription;
Steps to reproduce:
- Download and install the latest version of Mozilla VPN from[ ﹍Treeherder﹍|https://treeherder.mozilla.org/jobs?repo=mozilla-vpn-client];
- Login with the account from prerequisites and observe the activation screen from the VPN app;
- Turn the VPN on and observe the activation screen again.
Expected result:
- The globe icon representing the VPN state is correctly displayed.
Actual result:
- The globe icon representing the VPN state is missing regardless of the VPN state.
Notes:
- See the attached ss.
┆Issue is synchronized with this Jira Bug ┆author: Bianca Hidecuti
➤ Lesley Norton commented:
I’m not seeing this on my local dev build… but I’m also NOT seeing the ring animation, not to mention the shield icon and green circle are misaligned.
!Screen Shot 2022-07-29 at 6.18.56 PM.png|width=365,height=392!
➤ Bianca Hidecuti commented:
Lesley Norton , I am reproducing this issue only if using builds from Treeherder ( https://treeherder.mozilla.org/jobs?repo=mozilla-vpn-client&selectedTaskRun=PCpFkacHTn-sBWDWnLp0oQ.0 ). If using builds from Github, the globe icon is displayed.
➤ Lesley Norton commented:
Thank you for the clarification Bianca Hidecuti . Basti (Sebastian) Streich Any thoughts on what it is about the treeherder builds that would be causing this?
➤ Basti (Sebastian) Streich commented:
Lesley Norton - The first thing that comes to mind, on gh we use this build of qt created by Andrea Marchesini https://github.com/mozilla-mobile/qt_static_macos ( https://github.com/mozilla-mobile/qt_static_macos|smart-link )
on taskcluster we create one using the scripts/utils/compile_qt - maybe some flags are wierd?
➤ Santiago Andrigo commented:
I interrupt this broadcast to ask two noob questions:
Basti (Sebastian) Streich Lesley Norton What is treeherder and why do we have builds on both there and github?
Bianca Hidecuti When this is filed as affecting MacOS 11.6, does it also mean that it’s not found elsewhere? (in other words, if you found it somewhere else, would that constitute a separate bug report?)
➤ Valentina Virlics commented:
Santiago Andrigo
For the question addressed to Bianca - usually if we mention only a platform, that is the only place where we reproduce it. If we logged an issue, and at that time, it is only reproducing on one platform, and after few day, we find the EXACT behavior on other platforms also, we add a comment to the initial issue. If the steps to reproduce, differ (even if we have the same result) then, we log another issue.
➤ Santiago Andrigo commented:
Got it, thanks!
➤ Santiago Andrigo commented:
Moving this to ‘high’ since it’s not in production (only QA) as per the bug prioritization framework ( https://docs.google.com/document/d/1ryjue_UIYc_JZbONgj1Q1CXaha7pXtElEYoO814AHnw/edit# ). This does remain a release blocker issue though, given it’s pretty much front and center on the core user journey. Thanks for reporting!
➤ Andrea Marchesini commented:
This is a build issue. I wonder if we take the right QT lib/version.
Talking with Valentina, this can be reproduced in any treeherder build, but not with github CI builds.
➤ Lesley Norton commented:
Possibly helpful tidbit: I force this on macos by setting this property bool _fallbackQtQuickRenderer: QT_QUICK_BACKEND == "software" (main.qml, L22) to true.
➤ Basti (Sebastian) Streich commented:
[01.09.2022 13:01:01.275] Warning: qUncompress: Z_DATA_ERROR: Input data is corrupted [01.09.2022 13:01:01.275] Warning: Attempted to deserialize QShader with unknown version 0. [01.09.2022 13:01:01.275] Warning: ShaderEffect: Failed to deserialize QShader fromInteresing. - It seems the Qt5Compat shaders are broken in the bundle.
It’s super wierd. If i compile qt locally with the compile_qt script, i get the same result. Baku’s build thats also build using the same script has this tho 😕
Lesley Norton - More a general question, what if we would just use the svg-based version as default and remove our dependency on qt5compat shaders?
➤ Bianca Hidecuti commented:
Verified this as fixed on Mozilla VPN 2.10.0 (2.202209070605) - from Treeherder ( https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/HBBYW8cTRpy7IXoFPHnv2w/runs/0/artifacts/public/build/MozillaVPN.pkg ), while using MacOS 11.6. The globe icon representing the VPN state is correctly displayed.
Attaching postfix ss.
!Screen Shot 2022-09-07 at 17.14.12.png|width=1095,height=1006!