mozilla-vpn-client icon indicating copy to clipboard operation
mozilla-vpn-client copied to clipboard

Add benchmark for upload speed

Open flozia opened this issue 3 years ago • 1 comments

Description

Adds an upload benchmark to the speed test.

Reference

VPN-2519: Speed test upload benchmark

Checklist

  • [x] My code follows the style guidelines for this project
  • [x] I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • [x] I have performed a self review of my own code
  • [x] I have commented my code PARTICULARLY in hard to understand areas
  • [ ] I have added thorough tests where needed

flozia avatar Jul 26 '22 22:07 flozia

Codecov Report

Base: 70.34% // Head: 70.23% // Decreases project coverage by -0.11% :warning:

Coverage data is based on head (2d5be91) compared to base (7b1e226). Patch coverage: 10.25% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4080      +/-   ##
==========================================
- Coverage   70.34%   70.23%   -0.12%     
==========================================
  Files         256      256              
  Lines       16086    16131      +45     
  Branches     8131     8162      +31     
==========================================
+ Hits        11316    11329      +13     
- Misses       4370     4401      +31     
- Partials      400      401       +1     
Flag Coverage Δ
lottie_tests 56.33% <ø> (ø)
qml_tests 7.46% <0.00%> (-0.09%) :arrow_down:
unit_tests 70.66% <10.25%> (-0.13%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/constants.h 50.00% <ø> (ø)
src/featureslist.h 0.00% <0.00%> (ø)
src/networkrequest.h 0.00% <ø> (ø)
src/networkrequest.cpp 46.92% <10.52%> (-2.02%) :arrow_down:
src/addons/addon.cpp 65.96% <0.00%> (-0.35%) :arrow_down:
nebula/nebula.cpp 66.66% <0.00%> (ø)
src/addons/addon.h 100.00% <0.00%> (ø)
src/models/feature.cpp 67.34% <0.00%> (ø)
tests/unit/testaddon.cpp 100.00% <0.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Jul 27 '22 13:07 codecov-commenter

Added a feature flag for the upload benchmark that is disabled by default for now.

flozia avatar Oct 02 '22 18:10 flozia