Taskcluster: Stage Addon-Index

[strseb]

What we did in paring :) -> Moved the intial addon-bundle build into build, so we dont explode the type of kinds, as that can get messy. -> renamed the other one push-addons to be in line with the push-apk type naming -> Added the release index. also added the fix, that i apparently did not packport from 2.9

[codecov-commenter]

Codecov Report

Merging #4074 (e44a409) into main (4f1ff38) will increase coverage by 0.14%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4074      +/-   ##
==========================================
+ Coverage   28.89%   29.03%   +0.14%     
==========================================
  Files         217      233      +16     
  Lines       12336    12948     +612     
  Branches     6986     7278     +292     
==========================================
+ Hits         3564     3759     +195     
- Misses       3735     3918     +183     
- Partials     5037     5271     +234     

Flag	Coverage Δ
lottie_tests	56.33% <ø> (ø)
qml_tests	10.00% <ø> (-1.21%)	:arrow_down:
unit_tests	27.88% <ø> (+0.30%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/tasks/addon/taskaddon.cpp	0.00% <0.00%> (-30.00%)	:arrow_down:
src/statusicon.cpp	38.37% <0.00%> (-29.13%)	:arrow_down:
src/mozillavpn.h	34.28% <0.00%> (-17.23%)	:arrow_down:
tests/qml/mocconstants.cpp	25.00% <0.00%> (-8.34%)	:arrow_down:
src/addons/addonmessage.cpp	39.39% <0.00%> (-8.11%)	:arrow_down:
src/addons/addonguide.cpp	50.00% <0.00%> (-5.56%)	:arrow_down:
src/websocket/websockethandler.cpp	50.00% <0.00%> (-5.24%)	:arrow_down:
src/addons/addontutorial.cpp	43.01% <0.00%> (-3.42%)	:arrow_down:
tests/unit/mocnetworkrequest.cpp	28.00% <0.00%> (-2.00%)	:arrow_down:
tests/qml/mocmozillavpn.cpp	21.21% <0.00%> (-1.02%)	:arrow_down:
... and 66 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[gabrielBusta]

@strseb I ran into the issue on that latest decision task run in staging. This is how I fixed it

[gabrielBusta]

A couple of thoughts:

• Are we beetmoving just the compiled rcc files + manifest.json + manifest.json.sig? (not the ts files)
• Wrt to the addons path in the archive, after taking a closer look at addons/generate_all.py and addons/build.py, paths like pub/vpn/candidates/addons/<moz_build_date>/<file_name> and pub/vpn/candidates/addons/latest/<file_name> make sense to me

[strseb]

Are we beetmoving just the compiled rcc files + manifest.json + manifest.json.sig? (not the ts files)

Yes only the json/json.sig and rcc files.

Wrt to the addons path in the archive, after taking a closer look at addons/generate_all.py and addons/build.py, paths like pub/vpn/candidates/addons/<moz_build_date>/<file_name> and pub/vpn/candidates/addons/latest/<file_name> make sense to me

Those look good to me :)

cc @bakulf

[bakulf]

+1 for anything @strseb said in the previous comment.