mozilla-vpn-client icon indicating copy to clipboard operation
mozilla-vpn-client copied to clipboard

Experiment: Use CMake to build MacOS in CI

Open oskirby opened this issue 2 years ago • 2 comments

Description

In PR #3517 we added reasonably good support for building the VPN project on MacOS using CMake, but we stopped short of updating our CI to use it because it's not quite obvious how to get code-signing to work properly in CI. However, I didn't want to lose that work, so I have split off the CI changes into this PR.

Reference

Github pull request #3517 Github: #3479 (VPN-2186)

Checklist

  • [ ] My code follows the style guidelines for this project
  • [ ] I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • [ ] I have performed a self review of my own code
  • [ ] I have commented my code PARTICULARLY in hard to understand areas
  • [ ] I have added thorough tests where needed

oskirby avatar May 24 '22 07:05 oskirby

Codecov Report

Merging #3603 (e41513f) into cmake-macos (5f69923) will decrease coverage by 23.21%. The diff coverage is n/a.

@@               Coverage Diff                @@
##           cmake-macos    #3603       +/-   ##
================================================
- Coverage        62.59%   39.37%   -23.22%     
================================================
  Files              285      279        -6     
  Lines            17656    17456      -200     
  Branches          8821     9461      +640     
================================================
- Hits             11052     6874     -4178     
- Misses            4931     4982       +51     
- Partials          1673     5600     +3927     
Flag Coverage Δ
functional_tests 26.59% <ø> (-1.15%) :arrow_down:
lottie_tests 56.33% <ø> (ø)
qml_tests 12.85% <ø> (+1.62%) :arrow_up:
unit_tests 34.80% <ø> (-38.65%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/nativemessaging/helperserver.h 0.00% <0.00%> (-100.00%) :arrow_down:
src/adjust/adjustfiltering.h 1.26% <0.00%> (-98.74%) :arrow_down:
tests/unit/testfeature.cpp 13.67% <0.00%> (-86.33%) :arrow_down:
tests/unit/testandroidmigration.cpp 16.57% <0.00%> (-83.43%) :arrow_down:
tests/unit/testguide.cpp 18.11% <0.00%> (-81.11%) :arrow_down:
tests/unit/testserveri18n.cpp 20.00% <0.00%> (-80.00%) :arrow_down:
tests/unit/testtutorial.cpp 22.22% <0.00%> (-77.26%) :arrow_down:
tests/unit/testlocalizer.cpp 23.07% <0.00%> (-76.93%) :arrow_down:
tests/unit/testmodels.cpp 23.35% <0.00%> (-76.24%) :arrow_down:
tests/auth/main.cpp 24.00% <0.00%> (-76.00%) :arrow_down:
... and 147 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5f69923...e41513f. Read the comment docs.

codecov-commenter avatar May 24 '22 07:05 codecov-commenter

Do you think we can finish this PR for 2.11? We should add to our roadmap.

bakulf avatar Sep 21 '22 15:09 bakulf

Superseded by #4821

oskirby avatar Nov 08 '22 22:11 oskirby