mozilla-vpn-client icon indicating copy to clipboard operation
mozilla-vpn-client copied to clipboard

Use new v2 Apple IAP Guardian endpoint

Open data-sync-user opened this issue 3 years ago • 2 comments

Update to new /v2 endpoint that sends just the “original transaction id” (not the whole reciept) to guardian (which guardian forwards to fxa).

/v2 endpoint isn’t in guardian yet.

┆Issue is synchronized with this Jira Task

data-sync-user avatar Jan 21 '22 18:01 data-sync-user

➤ Betty Fleming commented:

Sarah Bird is monitoring pieces in Guardian and FxA related to this. We will schedule this client once Guardian work is at least in progress. (Probably 1.24 release in Guardian).

data-sync-user avatar Apr 06 '22 16:04 data-sync-user

➤ Jeremy Swinarton commented:

I’ve revised this ticket a bit – through discussion on https://docs.google.com/document/d/18Yy2bGSdTSvSdydm4dNOfUeMSBJuK9ZVRTcRM1ooBbo ( https://docs.google.com/document/d/18Yy2bGSdTSvSdydm4dNOfUeMSBJuK9ZVRTcRM1ooBbo ) we realized that we don’t need to tie the IAP migration to the v2 endpoint itself. When we release Guardian 1.26, all new IAP subscriptions will automatically be created as FxA subs, even if using the old v1 endpoint. We still plan to implement the v2 endpoint and deprecate the old one, because currently the client has to send us the whole Apple receipt (which can be quite large) whereas going forward only the original_transaction_id will be necessary. We would like to add this as part of 2.10 but it is not strictly required in order to start using FxA. (We also no longer need a dot release because of this.)

data-sync-user avatar Aug 09 '22 14:08 data-sync-user

➤ Valentina Virlics commented:

Jeremy Swinarton Do we have a due date for this implementation, so that QA team could start testing the Apple IAP subscriptions using the new endpoint? Thank you!

data-sync-user avatar Aug 18 '22 09:08 data-sync-user

➤ Betty Fleming commented:

Santiago Andrigo Adrienne Davenport This work needs to be done in the December sprint (2.13 release) to support the the cleanup in Guardian related to the IAP work. See description for more info on why we want to do this.

data-sync-user avatar Nov 21 '22 20:11 data-sync-user

➤ Santiago Andrigo commented:

Sarah Bird Jeremy Swinarton Moved this to the December sprint based off Betty’s comment.

data-sync-user avatar Nov 22 '22 16:11 data-sync-user

➤ Betty Fleming commented:

Jeremy SwinartonAdrienne Davenport Sarah Bird Santiago Andrigo moving to January sprint.

data-sync-user avatar Dec 27 '22 16:12 data-sync-user

➤ Jeremy Swinarton commented:

After a discussion with Sarah Bird we have decided to deprioritize this ticket. She correctly pointed out that we can remove ~95% of Apple IAP code from Guardian while the client remains on the v1 endpoint, and we will actually need to maintain it for some time for backward compatibility anyway. Recommendation is to go ahead with the IAP cleanup as part of Fried Chicken but leave this ticket for a later date.

data-sync-user avatar Apr 26 '23 15:04 data-sync-user