mozilla-vpn-client icon indicating copy to clipboard operation
mozilla-vpn-client copied to clipboard

Published 20 hours ago • verified publisher icon mozilla-mobile

Replace the XMLHttpRequest object for glean with a `Task`

Open bakulf opened this issue 3 years ago • 1 comments

In this way we are 100% sure we don't try to send pings when the VPN is changing states. This should be easy to do exposing a VPN.sendGleanPing(url, payload, headers)

┆Issue is synchronized with this Jira Task

bakulf avatar Jul 22 '21 18:07 bakulf

Probably a good thing to tackle at the same time as #1262

oskirby avatar Jul 22 '21 18:07 oskirby

➤ Andrea Marchesini commented:

Beatriz Rizental Machado can we close this?

data-sync-user avatar Nov 01 '22 09:11 data-sync-user

➤ Beatriz Rizental Machado commented:

Huh, I missed this question. So, hm. Maybe we should not close this. The problem will persist after Glean migration… However I am not sure there is a problem at all. Glean will simply retry to send a ping when upload is unsuccesfull. It’s fine it upload fails because the VPN is changing states.

data-sync-user avatar Nov 22 '22 15:11 data-sync-user

➤ Beatriz Rizental Machado commented:

This is not an issue. Glean deals with upload errors and retries internally.

data-sync-user avatar Jan 04 '23 09:01 data-sync-user

➤ Santiago Andrigo commented:

Moving back to Cancelled

data-sync-user avatar Jun 03 '24 16:06 data-sync-user

➤ Santiago Andrigo commented:

Moving back to Cancelled

data-sync-user avatar Jun 24 '24 17:06 data-sync-user