focus-ios icon indicating copy to clipboard operation
focus-ios copied to clipboard

Youtube videos do not play in full screen on iPad

Open dovanvu1792 opened this issue 2 years ago • 2 comments

Steps to reproduce

  1. Launch Focus
  2. Past and GO on address bar: https://www.youtube.com/watch?v=CwA1VWP0Ldw
  3. Tap on full screen button

Expected behavior

  • Videos should play in full screen.

Actual behavior

  • The full screen button is greyed out.

Device & build information

  • Device: IPAD 12.9 gen 6

┆Issue is synchronized with this Jira Task

dovanvu1792 avatar Sep 03 '23 08:09 dovanvu1792

For me it happens only after I reload the tab. If I simply open the same video twice, the full screen button remains active.

Upon pressing on the grayed-out full screen button, a tooltiop appears saying: Full screen mode is not supported by this browser

Turning Tracking Protection off has no effect.

sryze avatar Oct 22 '23 18:10 sryze

Adding

addScript(forResource: "FullScreen", injectionTime: .atDocumentStart, forMainFrameOnly: true)

to https://github.com/mozilla-mobile/focus-ios/blob/f16bfcf9e57a7a7a7e0b243be1846a5670158f0f/Blockzilla/Modules/WebView/WebViewController.swift#L238 seems to fix it

sryze avatar Oct 22 '23 19:10 sryze