focus-ios icon indicating copy to clipboard operation
focus-ios copied to clipboard

Unit test testListAdUrlsDuckDuckGo fails on Bitrise stack osx-xcode-14.1.x-ventura

Open clarmso opened this issue 2 years ago • 2 comments

Steps to reproduce

On bitrise.yml, upgrade the stack from osx-xcode-14.0.x to osx-xcode-14.1.x-ventura. Run the workflow [unit_test_focus](https://app.bitrise.io/build/7abf4349-67c5-4d30-b43a-9659209708ba) on Bitrise.

Expected behavior

All unit tests pass on Bitrise.

Actual behavior

ClientTests/trackingAdsTests/testListAdUrlsDuckDuckGo() fails with the following error message on Bitrise:

/Users/vagrant/git/ClientTests/SearchEngineTests.swift:72 - XCTAssertThrowsError failed: did not throw an error

https://addons-testing.bitrise.io/builds/7abf4349-67c5-4d30-b43a-9659209708ba/testreport/bebd0425-4749-4008-ba76-a1b1c6a978bf/testsuite/0/testcases?status=failed

🤷🏼 I can't reproduce the failure on my machine locally....yet.

Device & build information

  • Device: iOS simulator from XCode 14.1 running on MacOS 13 Ventura (osx-xcode-14.1.x-ventura)
  • Build version: ?

Notes

Attachments:

┆Issue is synchronized with this Jira Task

clarmso avatar Feb 13 '23 21:02 clarmso

Let me disable the test so that I can go ahead and upgrade the stack:

https://github.com/mozilla-mobile/focus-ios/pull/3689

clarmso avatar Feb 13 '23 21:02 clarmso

We need to upgrade the stacks since the current one is going to be deprecated on Bitrise. That should not affect the unit tests... worth investigating what could be the cause.

CC developers as owners of the Unit Tests: @razvanlitianu @PARAIPAN9

isabelrios avatar Feb 14 '23 08:02 isabelrios