focus-ios icon indicating copy to clipboard operation
focus-ios copied to clipboard

The colors on the Widget pop-up are inconsistent

Open abodea opened this issue 2 years ago • 6 comments

Steps to reproduce

  1. Launch focus and open any webpage.
  2. Clear the page by tapping on the trash icon.

Expected behavior

There should not be 4-5 different colors on a page.

Actual behavior

The colors on the Widget pop-up are inconsistent.

Device & build information

  • Device: iPhone 13 Pro (15.1.1)
  • Build version: v9000 (14557)

Notes

The X button depends on the theme way too light or way too dark but the widget pop-up color never changes no matter if it's dark or light theme. The Show me how color button is blue, note that on the Android side that color button is purple matching the focus theme. The Search in Focus widget presentation the purple is way too different from the dark theme of focus. Attachments:

image1 (1) unknown (2)

abodea avatar Sep 20 '22 13:09 abodea

Hello, @rtestard should we also, have a dark theme screen for this widget pop-up?

abodea avatar Sep 20 '22 13:09 abodea

Yes. Do you need UI for this though?

rtestard avatar Sep 20 '22 16:09 rtestard

@abodea the second screenshot in from Android, but yes, there's no dark mode design for iOS.

Screenshot 2022-09-21 at 16 09 43

@rtestard are we keeping the dialog always in light mode? Also in landscape the content is clipped, do we show it only in portrait?

razvanlitianu avatar Sep 21 '22 13:09 razvanlitianu

Per discussion let's not address the landscape mode (very rare instances, userrs acn always flip their phone). The dialogue should although support dark mode - @jeffreygee can you please help with the designs?

rtestard avatar Sep 21 '22 13:09 rtestard

Using the colors from the previous onboarding screens I got to this variant. @jeffreygee do you think it's okay? Can we add it also in Figma? Screenshot 2022-09-22 at 12 29 12 @rtestard

razvanlitianu avatar Sep 22 '22 09:09 razvanlitianu

@razvanlitianu - dark mode button color added to Figma

jeffreygee avatar Oct 11 '22 20:10 jeffreygee

Verified as fixed on v9000 (149180 with iPhone 13 Pro (15.1.1).

abodea avatar Oct 13 '22 09:10 abodea