focus-ios
focus-ios copied to clipboard
After removing a shortcut, show a confirmation message
Steps to reproduce
- Visit any website.
- Add it to the shortcuts.
- Tap on the hamburger menu while the page is open and tap on the
remove shortcut.
Expected behavior
A snack bar with the confirmation that the shortcut was successfully removed.
Actual behavior
No snack bar is displayed.
Device & build information
- Device: iPhone 13 Pro (15.1)
- Build version: 9000 (13720).
Notes
Attachments:
@rtestard, @jeffreygee Might be worth looking at this? It will help a lot and it's used in FF for iOS too.
I agree that a visual confirmation that the action was completed could be valuable. I assume the "snack bar" is the UI we use to display "Browsing history cleared" when the trash button gets used? This pattern feels like it could work well and in that case I assume that all we need is content.
I propose we use "Address removed from shortcuts"
@emilyw can you please help review content change proposal here?
Yes, I think we can just say "Shortcut removed" and use the same style as the history cleared confirmation
Similar with https://github.com/mozilla-mobile/focus-ios/issues/3369, we are missing the toast but we can add it as soon as we have a confirmation on the string. Is "Shortcut removed" ok?
@rtestard
Added QA needed until the confirmation/implementation.
@ewachowiak can you please confirm?
Yes, "Shortcut removed" is approved as the string.
Verified as fixed on v9000 (14145) iPhone 13 Pro Max iOS (15.1.1).