focus-ios icon indicating copy to clipboard operation
focus-ios copied to clipboard

After removing a shortcut, show a confirmation message

Open abodea opened this issue 3 years ago • 5 comments
trafficstars

Steps to reproduce

  1. Visit any website.
  2. Add it to the shortcuts.
  3. Tap on the hamburger menu while the page is open and tap on the remove shortcut.

Expected behavior

A snack bar with the confirmation that the shortcut was successfully removed.

Actual behavior

No snack bar is displayed.

Device & build information

  • Device: iPhone 13 Pro (15.1)
  • Build version: 9000 (13720).

Notes

Attachments:

abodea avatar Aug 02 '22 11:08 abodea

@rtestard, @jeffreygee Might be worth looking at this? It will help a lot and it's used in FF for iOS too.

abodea avatar Aug 02 '22 11:08 abodea

I agree that a visual confirmation that the action was completed could be valuable. I assume the "snack bar" is the UI we use to display "Browsing history cleared" when the trash button gets used? This pattern feels like it could work well and in that case I assume that all we need is content.

I propose we use "Address removed from shortcuts"

@emilyw can you please help review content change proposal here?

rtestard avatar Aug 10 '22 11:08 rtestard

Yes, I think we can just say "Shortcut removed" and use the same style as the history cleared confirmation

ewachowiak avatar Aug 10 '22 17:08 ewachowiak

Similar with https://github.com/mozilla-mobile/focus-ios/issues/3369, we are missing the toast but we can add it as soon as we have a confirmation on the string. Is "Shortcut removed" ok?

@rtestard

razvanlitianu avatar Aug 12 '22 07:08 razvanlitianu

Added QA needed until the confirmation/implementation.

abodea avatar Aug 12 '22 15:08 abodea

@ewachowiak can you please confirm?

rtestard avatar Aug 17 '22 09:08 rtestard

Yes, "Shortcut removed" is approved as the string.

ewachowiak avatar Aug 17 '22 13:08 ewachowiak

Verified as fixed on v9000 (14145) iPhone 13 Pro Max iOS (15.1.1).

abodea avatar Sep 05 '22 08:09 abodea