Search telemetry addition

[rtestard]

User proposal

As a product manager, I want to understand how Focus iOS contributes to the business so that I can keep bringing great features to Focus.

Ideas for Solution

Implement search probes similar to Focus Android or Firefox iOS when Focus Android probe does not exist

• Count of partner search pages w/ ad: https://dictionary.telemetry.mozilla.org/apps/focus_android/metrics/browser_search_with_ads
• Count of search results ad clicks: https://dictionary.telemetry.mozilla.org/apps/focus_android/metrics/browser_search_ad_clicks
• Follow-on search counts: https://dictionary.telemetry.mozilla.org/apps/focus_android/metrics/browser_search_in_content
• Organic search counts: https://dictionary.telemetry.mozilla.org/apps/focus_android/metrics/browser_search_in_content
• SAP search counts and categorization (i.e. urlbar, widget, suggestion, etc.): https://dictionary.telemetry.mozilla.org/apps/firefox_ios/metrics/search_counts

[rtestard]

https://github.com/mozilla-mobile/focus-ios/pull/2826 is related

[Dexterp37]

@rtestard note that the default search engine seem to be missing as well.

[rtestard]

@Dexterp37 thanks, now added it in initial comment with reference to https://dictionary.telemetry.mozilla.org/apps/focus_android/metrics/browser_default_search_engine

[Dexterp37]

Thank you @rtestard . Is there any chance this could get prioritized?

[rtestard]

@CatalinNeculaide @razvanlitianu Please let me know if i should file a separate issue for the search engine addition part I added to scope. I now realize it got added as the issue was in QA so maybe best to address as a separate issue?

[razvanlitianu]

Yes, separate issue is okay @rtestard

[rtestard]

Sounds good i raised https://github.com/mozilla-mobile/focus-ios/issues/3475 and removed default search engine from the initial comment

[abodea]

Hello, @rtestard, @razvanlitianu, @CatalinNeculaide can you please clarify:

• Can you please clarify if this issue is for:

  • Count of partner search pages w/ ad -> search any page where any ad is displayed -> what is the trigger point and what should be displayed in the glean debugger the string name? ->
  • Count of search results ad clicks: -> Tap on any ad from any web page should register a string name in the event/metrics/baseline pings?
  • Follow-on search counts: -> How this should be displayed in the glean debug in order to see if it's working and what is the trigger of it? A simple search?
  • Organic search counts: -> How this should be displayed in the glean debug in order to see if it's working? Just normal searches?
  • SAP search counts and categorization (i.e. urlbar, widget, suggestion, etc.): -> How this should be displayed in the glean debug in order to see if it's working?

After a simple search with the Google search engine as default I managed to trigger this but nothing more.

[rtestard]

Yes this bug is for all 5, there are also follow-on bugs for search telemetry not part of this scope, (we decided to split deliveries): https://github.com/mozilla-mobile/focus-ios/issues/3475 https://github.com/mozilla-mobile/focus-ios/issues/3479 https://github.com/mozilla-mobile/focus-ios/issues/3478

[abodea]

Yes this bug is for all 5, there are also follow-on bugs for search telemetry not part of this scope, (we decided to split deliveries): #3475 #3479 #3478

Thank you! I saw the bugs but I still need help with all the questions after each section I mentioned above.

[rtestard]

Oh sorry i missed it. @Dexterp37 can you please help Andrei here with his questions on https://github.com/mozilla-mobile/focus-ios/issues/3330#issuecomment-1266814538?

[Dexterp37]

Oh sorry i missed it. @Dexterp37 can you please help Andrei here with his questions on #3330 (comment)?

@rtestard this is a question that should probably be answered by the engineer who implemented this. If the desired behaviour is unclear, the best option is to talk to Fenix engineers or see how it behaves there. Unfortunately, I'm not familiar with the implementation of these.

[CatalinNeculaide]

Hi, @abodea i can answer those questions:

• Count of partner search pages w/ ad -> search any page where any ad is displayed -> what is the trigger point and what should be displayed in the glean debugger the string name? A: In Glean it should display the provider (ex: Google, Bing, Yahoo, DuckDuckGo) and the counter of how many times the event has been triggered. How i got the event triggered was searching on Google for iphone, tv, ps5 etc
• Count of search results ad clicks: -> Tap on any ad from any web page should register a string name in the event/metrics/baseline pings? A: After you trigger the search with ads you can get this event by clicking on any ads that appear on page.

[abodea]

Thank you @CatalinNeculaide! Verified as fixed on v 9000 (14918) with iPhone 13 Pro (15.1.1).

{"browser_search.ad_clicks":{"provider-google":1},"browser_search.in_content":{"google.in-content.sap.firefox-b-m":9,"google.organic.none":2,"none.in-content.sap.none":1},"browser_search.search_count":{"action":10},"browser_search.with_ads":{"provider-google":4},"glean.validation.pings_submitted":{"baseline":5,"deletion-request":1,"events":2,"metrics":1}}