"Open Link" in page preview opens in external browser instead of Focus

[SimonBasca]

Steps to reproduce

1. Visit "news.google.com"
2. Long press on a link
3. Tap "Open Link"

Expected behavior

• The "Open Link" should be changed to something more specific. e.g : Open in Default Browser.

Actual behavior

• The link will open in the default browser.

Device & build information

• Device: iPhone 12 Pro (15.1)
• Build version: 96.0 (10088)

Notes

Attachments:

[st3fan]

I think what we should do here instead is make Open Link work so that it opens in Focus and not in another browser. I renamed the issue to reflect that.

[rtestard]

Agreed, "Open link" should open the link inside Focus

[razvanlitianu]

@rtestard It seems we can overwrite the menu and provide our own custom actions and it can look like this.

We can also restore the preview.

So I think all that's left is to come up with the actions that we want to support. Here is a look at Firefox.

[rtestard]

Thanks. I think we should have these options:

• Open Link (Firefox icon you have in your mock) - opens the link inside Focus
• Copy Link (Existing Copy icon) - copies link (current behavior)
• Share... (Existing share icon) - opens sharing intent (current behavior)

Why?

• As far as I can tell these are the only options relevant to focus
• The current copy seems right, retaining it will avoid localisation issues @jeffreygee any concerns there?

[jeffreygee]

@rtestard I think that should be fine!

@razvanlitianu would it carry over the same Share tray as on Firefox?

[razvanlitianu]

@jeffreygee yes, it's the default on iOS.

[razvanlitianu]

@rtestard we have feature on the homepage menu in browsing mode to open a link in default browser, so if Focus if the default browser it will open the link within itself, if not it will open the default browser. Just wanted to double check if the link on this preview menu should open the link in Focus, or the Default Browser?

[razvanlitianu]

I'm trying to see what is the best interaction here. If the user wants to open the page within Focus, it can simply tap the link without holding it. I assume the tap and hold needs to offer some extra functionality. @jeffreygee what do you think it's the best experience?

[rtestard]

I agree, the open action should be "open in default browser application".

[jeffreygee]

Adding in @ewachowiak to make sure there are no content concerns here.

@razvanlitianu @rtestard - I think it's okay to keep it Open Link as the main one with the potential second option of Open in Default Browser.

So the tap + hold menu would look something like:

• Open Link (Firefox icon you have in your mock) - opens the link inside Focus
• Open Link in Default Browser (Existing browser icon) - open the link in Default Browser
• Copy Link (Existing Copy icon) - copies link (current behavior)
• Share... (Existing share icon) - opens sharing intent (current behavior)

Removing the primary function from the long tap would be bad for accessibility, but it would be okay to add something in addition to it.

[ewachowiak]

I agree with @jeffreygee that offering the options above is ideal to give users a way to carry the link to their preferred browser if they want to keep it more permanent. Longer term, we should look at what percentage of users DO make Focus their default browser but I think that number will not be the majority.

Are we removing "Add to Reading List" from the menu? It is there today above Copy Link. If we keep it perhaps it should go below Copy Link & above Share--assumption is that Reading List is not a widely used feature. FYI @rtestard

[razvanlitianu]

@rtestard Can we create a separate ticket for the additional work? Currently I'm merging the work to fix the bug.

[rtestard]

Thanks I opened https://github.com/mozilla-mobile/focus-ios/issues/3528 as a follow-up to add the "Open Link in Default Browser" option @ewachowiak Yes the intention is to remove "Add to Reading List" given it's un-intuitive/unexpected that a browser feature would add to another browser reading list.

[abodea]

Verified as fixed on v9000 (15188) with iPhone 13 Pro (15.1.1).